Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix envoy build failed with unused variable factory_name #13125

Closed
wants to merge 3 commits into from
Closed

fix envoy build failed with unused variable factory_name #13125

wants to merge 3 commits into from

Conversation

RuijingGuo
Copy link

Commit Message: fix envoy build failed with unused variable factory_name
Additional Description:n/a
Risk Level:n/a
Testing:n/a
Docs Changes: n/a
Release Notes:n/a

@RuijingGuo
fix envoy build failed with unused variable factory_name
9c86553 
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
@RuijingGuo RuijingGuo mentioned this pull request Sep 16, 2020
Closed
asraa
asraa previously approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@asraa asraa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you fix format please?

@asraa asraa self-assigned this Sep 16, 2020
@htuch
Copy link
Member

htuch commented Sep 16, 2020

Thanks @guoruijing. I'm wondering if we can figure out what's up with #13079 (comment) as well.

@mattklein123
Copy link
Member

Looks like this needs a format fix.

/wait

@RuijingGuo
fix envoy build failed with unused variable factory_name
1b0e614 
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
@RuijingGuo
fix envoy build failed with unused variable factory_name
9df048e 
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
@stale
Copy link

stale bot commented Oct 4, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 4, 2020
@mattklein123 mattklein123 removed the stale stalebot believes this issue/PR has not been touched recently label Dec 9, 2020
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 8, 2021
@github-actions
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asraa asraa asraa left review comments

Assignees

@asraa asraa

Labels
stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RuijingGuo @htuch @mattklein123 @asraa