Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuzz] Fixed crashing fuzz test in Http Health Check Fuzz #13219

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Sep 22, 2020

Signed-off-by: Zach Reyes zasweq@google.com

Commit Message: Fixed crashing fuzz test in Http Health Check Fuzz
Additional Description:
The http utility function getResponseStatus() throws an exception. This problem falls within the high level design issue of #10878. I will follow up after finishing gRPC health check fuzzing to remove expections in http utility functions. @yanavlasov
Risk Level: Low
Testing:
Docs Changes:
Release Notes:

Signed-off-by: Zach <zasweq@google.com>
@zasweq
Copy link
Contributor Author

zasweq commented Sep 22, 2020

/assign @asraa @yanavlasov

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question!

test/common/upstream/health_check_fuzz.cc Outdated Show resolved Hide resolved
Signed-off-by: Zach <zasweq@google.com>
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick comments!
/wait

test/common/upstream/health_check_fuzz.h Outdated Show resolved Hide resolved
test/common/upstream/health_check_fuzz.proto Show resolved Hide resolved
Signed-off-by: Zach <zasweq@google.com>
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asraa
Copy link
Contributor

asraa commented Sep 24, 2020

/retest envoy-presubmit

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13219 (comment) was created by @asraa.

see: more, trace.

@asraa asraa merged commit 6b0c18d into envoyproxy:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants