Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI: Upload test results to AZP #14083

Merged
merged 4 commits into from
Nov 20, 2020
Merged

Windows CI: Upload test results to AZP #14083

merged 4 commits into from
Nov 20, 2020

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Nov 18, 2020

Commit Message:
Windows: Upload test results to AZP

  • Requires modifying --output_base flag to Bazel startup options
  • The TEST_TMPDIR and BUILD_DIR bind mounts from the host are where
    Bazel will place build output etc.
  • Allowing Bazel to place build and test output there will give the host
    access to the data to upload
  • Only riskiness involves Windows and long paths, adds a couple characters
    to the exec root/output base Bazel uses
  • Should help with diagnosing test flakiness on Windows, having test results actually
    uploaded to AZP so we can track failures over time

Additional Description: N/A
Risk Level: Low
Testing: N/A, CI change
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

@sunjayBhatia sunjayBhatia changed the title Windows: Upload test results to AZP Windows CI: Upload test results to AZP Nov 18, 2020
@sunjayBhatia
Copy link
Member Author

@envoyproxy/windows-dev

@sunjayBhatia
Copy link
Member Author

See https://dev.azure.com/cncf/envoy/_build/results?buildId=57958&view=ms.vss-test-web.build-test-results-tab should be able to filter now for windows test results

- Requires removing --output_base flag to Bazel startup options
- The TEST_TMPDIR and BUILD_DIR bind mounts from the host are where
  Bazel will place build output etc.
- Allowing Bazel to place build and test output there will give the host
  access to the data to upload

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
CI no longer will use C:/_eb as an output base

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia
Copy link
Member Author

/wait

trying to minimize path length increases

Ensure local builds still work out of the box

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
@sunjayBhatia
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14083 (comment) was created by @sunjayBhatia.

see: more, trace.

…-results

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia
Copy link
Member Author

merged master to get coverage to hopefully pass, shouldnt be affected by this change

@mattklein123 mattklein123 merged commit 6a2ea36 into envoyproxy:master Nov 20, 2020
andreyprezotto pushed a commit to andreyprezotto/envoy that referenced this pull request Nov 24, 2020
- Requires removing --output_base flag to Bazel startup options
- The TEST_TMPDIR and BUILD_DIR bind mounts from the host are where
  Bazel will place build output etc.
- Allowing Bazel to place build and test output there will give the host
  access to the data to upload

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
qqustc pushed a commit to qqustc/envoy that referenced this pull request Nov 24, 2020
- Requires removing --output_base flag to Bazel startup options
- The TEST_TMPDIR and BUILD_DIR bind mounts from the host are where
  Bazel will place build output etc.
- Allowing Bazel to place build and test output there will give the host
  access to the data to upload

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: Qin Qin <qqin@google.com>
@sunjayBhatia sunjayBhatia deleted the windows-upload-test-results branch November 30, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants