Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 5: Add clang cl pipeline for Windows #14135

Closed
wants to merge 7 commits into from
Closed

Step 5: Add clang cl pipeline for Windows #14135

wants to merge 7 commits into from

Conversation

wrowe
Copy link
Contributor

@wrowe wrowe commented Nov 21, 2020

Commit Message: Step 5: Add clang cl pipeline for Windows
Additional Description:

Now that we have regenerated envoy build tools to update bazel and llvm, introduce a clang-cl pipeline based on clang-cl

Co-authored-by: Sunjay Bhatia sunjayb@vmware.com

Risk Level: low (new facility)
Testing: local
Docs Changes: TBD
Release Notes: TBD
Platform Specific Features: Windows clang-cl compilation
Requires #13688
Fixes #11974

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 21, 2020
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #14135 was opened by wrowe.

see: more, trace.

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: William A Rowe Jr <wrowe@vmware.com>

Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
@wrowe
Copy link
Contributor Author

wrowe commented Dec 14, 2020

The most recent push dropped the step 2 patch of the bazel version number change, that's still ambiguous.

Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
@wrowe wrowe marked this pull request as ready for review December 17, 2020 20:39
@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14135 (comment) was created by @wrowe.

see: more, trace.

Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
@wrowe
Copy link
Contributor Author

wrowe commented Jan 5, 2021

Now that lizan picked up step 4, going to retry a couple times with the new tooling. We did something specific in this patch which can be changed... the clang pipelines runs after the msvc pipeline, mostly to give the msvc build all the compute it needs to get finished. But depending on how gcp rbe behaves, we could invoke them in parallel.

Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
@wrowe
Copy link
Contributor Author

wrowe commented Jan 8, 2021

This is being rescheduled to 1.18-dev, and will be moved to the windows-ga
milestone once the interesting half... #14608 has been merged, and
this commit rebased down to simply a new pipeline.

The flake and the fail noted from //test/common/network:dns_impl_test and //test/extensions/filters/network/sni_dynamic_forward_proxy:proxy_filter_integration_test
need to be added to this patch, but specific only to clang-cl builds, since msvc-cl
builds seem to be unaffected.

@wrowe
Copy link
Contributor Author

wrowe commented Jan 12, 2021

This patch was split into 14608 (applied) and 14668 (draft).

Closing this ticket to retire the github org it was pulled from.

@wrowe wrowe closed this Jan 12, 2021
@wrowe wrowe deleted the add-clang-cl-pipeline branch January 12, 2021 14:43
htuch pushed a commit that referenced this pull request Jan 29, 2021
Now that we have regenerated envoy build tools to update bazel and llvm, and picked up the llvm 11 tooling for windows on envoyproxy/master, finally introduce a clang-cl pipeline based on clang-cl

Risk Level: low (new facility)
Testing: local
Docs Changes: TBD
Release Notes: TBD
Platform Specific Features: Windows clang-cl compilation
Replaces #14135
Fixes #11974

Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows builds with clang-cl.exe
4 participants