Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport to 1.14: udp: properly handle truncated/dropped datagrams (#14122) #14192

Merged
merged 4 commits into from
Dec 1, 2020

Conversation

cpakulski
Copy link
Contributor

Commit Message:
properly handle truncated/dropped datagrams

Additional Description:
Risk Level: Med
Testing:Unit tests
Docs Changes: No
Release Notes: Yes

Fixes #14113

cpakulski and others added 3 commits November 25, 2020 20:28
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Co-authored-by: Matt Klein <mklein@lyft.com>
Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
@cpakulski
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14192 (comment) was created by @cpakulski.

see: more, trace.

@antoniovicente antoniovicente self-requested a review December 1, 2020 05:26
@antoniovicente antoniovicente self-assigned this Dec 1, 2020
* On different platforms the sockaddr struct for unix domain
* sockets is different. We use this function to get the
* length of the platform specific struct.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment sneaked in from a different patch.

Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
@cpakulski cpakulski marked this pull request as ready for review December 1, 2020 17:51
@antoniovicente antoniovicente merged commit 21ad0d9 into envoyproxy:release/v1.14 Dec 1, 2020
@cpakulski cpakulski deleted the rel1.14/14122 branch December 14, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants