Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[gzip]: allow gzip to work w/ http2 backend w/o content-lengt… #14567

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

rgs1
Copy link
Member

@rgs1 rgs1 commented Jan 5, 2021

…h (#14405)"

This reverts commit 0c9e7bf.

This breaks web sockets because it forces compression on upgrade responses
(when apparently it shouldn't).

Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com

envoyproxy#14405)"

This reverts commit 0c9e7bf.

This breaks web sockets because it forces connections on upgrade responses
(when apparently it shouldn't).

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
@mattklein123 mattklein123 self-assigned this Jan 5, 2021
@rgs1
Copy link
Member Author

rgs1 commented Jan 6, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14567 (comment) was created by @rgs1.

see: more, trace.

@alyssawilk alyssawilk merged commit 3d3b42e into envoyproxy:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants