Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows-specific filegroup to capture envoy-static.pdb output file from opt build #16043

Merged
merged 5 commits into from
Oct 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.1.0
4.2.1
4 changes: 3 additions & 1 deletion bazel/envoy_binary.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ def envoy_cc_binary(
stamped = False,
deps = [],
linkopts = [],
tags = []):
tags = [],
features = []):
if not linkopts:
linkopts = _envoy_linkopts()
if stamped:
Expand All @@ -42,6 +43,7 @@ def envoy_cc_binary(
stamp = 1,
deps = deps,
tags = tags,
features = features,
)

# Select the given values if exporting is enabled in the current build.
Expand Down
4 changes: 3 additions & 1 deletion ci/windows_ci_steps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,13 @@ fi
if [[ $BUILD_ENVOY_STATIC -eq 1 ]]; then
bazel "${BAZEL_STARTUP_OPTIONS[@]}" build "${BAZEL_BUILD_OPTIONS[@]}" //source/exe:envoy-static

# Copy binary to delivery directory
# Copy binary and pdb to delivery directory
cp -f bazel-bin/source/exe/envoy-static.exe "${ENVOY_DELIVERY_DIR}/envoy.exe"
cp -f bazel-bin/source/exe/envoy-static.pdb "${ENVOY_DELIVERY_DIR}/envoy.pdb"

# Copy for azp, creating a tar archive
tar czf "${ENVOY_BUILD_DIR}"/envoy_binary.tar.gz -C "${ENVOY_DELIVERY_DIR}" envoy.exe
tar czf "${ENVOY_BUILD_DIR}"/envoy_binary_debug.tar.gz -C "${ENVOY_DELIVERY_DIR}" envoy.exe envoy.pdb
davinci26 marked this conversation as resolved.
Show resolved Hide resolved
fi

# Test invocations of known-working tests on Windows
Expand Down
4 changes: 4 additions & 0 deletions source/exe/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ alias(

envoy_cc_binary(
name = "envoy-static",
features = select({
"//bazel:windows_opt_build": ["generate_pdb_file"],
"//conditions:default": [],
}),
stamped = True,
deps = [":envoy_main_entry_lib"],
)
Expand Down