Disable fuzz coverage test on Bazel CI #16940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @meteorcloudy, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
@antoniovicente assign you because you seem to have some background based on the referenced issue. |
|
@meteorcloudy it might be worth discussing the path forward with @antoniovicente first, but if we're going to proceed with this PR, we'll need DCO signoff (see https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md#dco-sign-your-work) |
envoyproxy#16542 has been keep Envoy red on Bazel CI for a long time, it doesn't make sense to keep a failing test if it's not going to be fixed. Signed-off-by: Yun Peng <pcloudy@google.com>
antoniovicente
approved these changes
Jun 14, 2021
|
That sounds good, as an aside I think the problem may be related to some libc++ flag configuration? |
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
envoyproxy#16542 has been keep Envoy red on Bazel CI for a long time, it doesn't make sense to keep a failing test if it's not going to be fixed. Signed-off-by: Yun Peng <pcloudy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16542 has been keep Envoy red on Bazel CI for a long time, it doesn't make sense to keep a failing test if it's not going to be fixed.