dist: Add debian packaging #17979
dist: Add debian packaging #17979
Conversation
repokitteh-read-only
bot
added
the
deps
phlax
force-pushed
the
dist-debian
branch
12 times, most recently
from
e349a3c
to
605cffe
Compare
phlax
force-pushed
the
dist-debian
branch
6 times, most recently
from
4116d9d
to
451e77b
Compare
yep, my thought too - hence the easier path of just removing the problem dep |
|
re the docker build - the artefacts/context changed so that would cause a rebuild - not sure that there is caching going on in the envoy-build-tools build - so i think it rebuilds all on every run regardless if it hadnt rebuilt theres a bunch of things that would not work (ie on x86) - it took quite a bit of local/staging testing to get it working currently none of the tooling is actually tested on arm - with the exception of the run that is added in this pr - so its mostly not something we hit |
|
I think I found the issue with your build container build: |
|
maybe - altho im wondering whether any of the subsequent code there would be necessary - gcc is already installed at this point, and links etc should have been made - defo a possibility tho |
|
Well you install gcc-9 from some PPA, not from official releases (likely because it is not in 18.04 - it would be in 20.04 though...). Not sure after all your packages which would be the default (no suffix) gcc in that container otherwise... |
|
aargghh - this is still an issue as re general points on the image @MarkusTeufelberger - i would encourage you to raise ticket/s in the envoy-build-tools repo and/or raise it on the relevant slack channel |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
|
@MarkusTeufelberger I have raised a PR to update the build image with your fix here #20391 Ive also picked the update on this PR, so hopefully the arm build should be fixed now - thanks for that |
Signed-off-by: Ryan Northey <ryan@synca.io>
|
/retest |
|
Retrying Azure Pipelines: |
|
cc @lizan tests are passing again |
Signed-off-by: Ryan Northey <ryan@synca.io>
ci/do_ci.sh
Outdated
| # and the packages signed with it, for the purpose of testing only. | ||
| if ! gpg --list-secret-keys "*"; then | ||
| export PACKAGES_MAINTAINER_NAME="Envoy CI" | ||
| export PACKAGES_MAINTAINER_EMAIL="envoy@snake.oil" |
There was a problem hiding this comment.
Is it real mail? I do not see it in the doc.
There was a problem hiding this comment.
it is not - and is intended to denote that - perhaps this could be more explicit in some way
There was a problem hiding this comment.
Use envoy@packaging.example.com perhaps?
There was a problem hiding this comment.
updated to envoy-ci@for.testing.only
|
@lizan would you mind giving this another pass - im v open to any suggestions on how we structure this |
|
@lizan can you PTAL? |
|
@lizan this has been stalled 9 days waiting on your review. Can you please take a look today? |
|
ill merge main now, and check its not failing |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
|
Check CI? Otherwise LGTM. |
|
Retrying Azure Pipelines: |
|
ill merge this now - i suspect this will take a few iterations to optimize, but this is a major milestone/component to adding a release pipeline |
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
Signed-off-by: Ryan Northey <ryan@synca.io>
Commit Message: dist: Add debian packaging
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]