Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: add getifaddrs to os syscalls #18513

Merged
merged 7 commits into from
Oct 9, 2021
Merged

syscall: add getifaddrs to os syscalls #18513

merged 7 commits into from
Oct 9, 2021

Conversation

junr03
Copy link
Member

@junr03 junr03 commented Oct 8, 2021

Commit Message: syscall - add getifaddrs to os syscalls
Additional Description: formalize getifaddrs into os syscalls.
Risk Level: low
Testing: existing calling code and UT over that code.

syscall: add getifaddrs to os syscalls
551f66f 
Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03 junr03 mentioned this pull request Oct 8, 2021
Merged
spelling
bf30fcf 
Signed-off-by: Jose Nino <jnino@lyft.com>
mattklein123
mattklein123 requested changes Oct 8, 2021
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Should there be some test for this?

/wait

envoy/common/platform.h Outdated Show resolved Hide resolved
test/common/network/utility_test.cc Outdated Show resolved Hide resolved
@junr03
Copy link
Member Author

junr03 commented Oct 8, 2021

Should there be some test for this?

AFAICT there is no direct testing class for OsSysCalls, but instead the functions are indirectly covered by tests that use them. In this case the test that covers Network::Utility::getLocalAddress

uncomment
e37f093 
Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03 junr03 mentioned this pull request Oct 8, 2021
Merged
Jose Nino added 2 commits October 8, 2021 15:23
clean up platform
e6af1dd 
Signed-off-by: Jose Nino <jnino@lyft.com>
clean up platform
07511ab 
Signed-off-by: Jose Nino <jnino@lyft.com>
mattklein123
mattklein123 previously approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

const
88e2695 
Signed-off-by: Jose Nino <jnino@lyft.com>
mattklein123
mattklein123 previously approved these changes Oct 8, 2021
View reviewed changes
fmt
82cc531 
Signed-off-by: Jose Nino <jnino@lyft.com>
phlax
phlax approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the basis of tacit approval from @mattklein123 - lgtm

@junr03 junr03 merged commit fc04382 into main Oct 9, 2021
goaway added a commit to goaway/envoy that referenced this pull request Oct 11, 2021
@goaway
Revert "syscall: add getifaddrs to os syscalls (envoyproxy#18513)"
dd0881e 
This reverts commit fc04382.

Signed-off-by: Mike Schore <mike.schore@gmail.com>
@goaway goaway mentioned this pull request Oct 11, 2021
Merged
mattklein123 pushed a commit that referenced this pull request Oct 11, 2021
@goaway
Revert "syscall: add getifaddrs to os syscalls (#18513)" (#18566)
b777701 
This reverts commit fc04382.

Signed-off-by: Mike Schore <mike.schore@gmail.com>
@mattklein123 mattklein123 deleted the getifaddrs-syscall branch November 9, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlax phlax phlax approved these changes

@mattklein123 mattklein123 mattklein123 left review comments

Assignees

@mattklein123 mattklein123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junr03 @phlax @mattklein123