Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream: fix typo in comment #18798

Merged
merged 1 commit into from
Oct 28, 2021
Merged

upstream: fix typo in comment #18798

merged 1 commit into from
Oct 28, 2021

Conversation

mergeconflict
Copy link
Member

Fix typo in comment, causing git push spellcheck hook to complain.

Signed-off-by: Dan Rosen mergeconflict@google.com

Signed-off-by: Dan Rosen <mergeconflict@google.com>
@repokitteh-read-only
Copy link

@envoyproxy/first-pass-reviewers cannot be assigned to this issue.

🐱

Caused by: a #18798 (comment) was created by @mergeconflict.

see: more, trace.

@repokitteh-read-only
Copy link

@envoyproxy/maintainers cannot be assigned to this issue.

🐱

Caused by: a #18798 (comment) was created by @mergeconflict.

see: more, trace.

@repokitteh-read-only
Copy link

@envoyproxy/maintainers assignee is @None

🐱

Caused by: a #18798 (comment) was created by @mergeconflict.

see: more, trace.

@mergeconflict
Copy link
Member Author

/assign @adisuissa

@mergeconflict
Copy link
Member Author

/review @adisuissa

@phlax phlax enabled auto-merge (squash) October 27, 2021 19:35
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phlax phlax merged commit a966aa8 into envoyproxy:main Oct 28, 2021
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 29, 2021
* main: (221 commits)
  deps: Bump `protobuf` -> 3.19.0 (envoyproxy#18471)
  tooling: auto-assign dependency shephards (envoyproxy#18794)
  clang-tidy: Return from diff fun if empty diff (envoyproxy#18815)
  repokitteh: Block PRs pending deps approval (envoyproxy#18814)
  deps: Bump `org_llvm_llvm` -> 12.0.1, `com_github_wavm_wavm` -> 9ffd3e2 (envoyproxy#18747)
  dns resolvers: add All lookup mode (envoyproxy#18464)
  doc: fix link formatting for TLS session_timeout (envoyproxy#18790)
  ext_authz: Set response flag and code details to UAEX when denied (envoyproxy#18740)
  socket options: add support for directly creating ipv4/ipv6 pairs (envoyproxy#18769)
  ecds: make onConfigUpdate generic over filter type (envoyproxy#18061)
  bazel: update CMake instructions in EXTERNAL_DEPS.md (envoyproxy#18799)
  upstream: fix typo in comment (envoyproxy#18798)
  runtime: removing envoy.reloadable_features.grpc_json_transcoder_adhere_to_buffer_limits (envoyproxy#18696)
  bazel: Add CC=clang to clang configuration (envoyproxy#18732)
  fix error request id in the dubbbo local reply (envoyproxy#18741)
  event: assert the case of both read and closed event registered (envoyproxy#18265)
  tcp proxy connect tunneling: improved testing (envoyproxy#18784)
  deps: Bump `protoc-gen-validate` -> 0.6.2 (envoyproxy#18742)
  deps: Bump `rules_pkg` -> ad57589 (envoyproxy#18746)
  bazel: copy .bazelversion for envoy filter examples (envoyproxy#18730)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
@mergeconflict mergeconflict deleted the typo branch October 29, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants