Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Emulate MSG_PEEK by read #19777

Merged
merged 45 commits into from
Feb 16, 2022
Merged

Windows: Emulate MSG_PEEK by read #19777

merged 45 commits into from
Feb 16, 2022

Commits on Nov 4, 2021

  1. Windows: Emulate MSG_PEEK by read 

    Commit Message:

The way we implement i/o events on windows poses problems with peeking messages.

The reason for that is that peeking does not drain the buffer which is an implicit
requirement. This can cause slow clients to make envoy connections to hang.

We solve this issue by implementing peek by draining the socket and storing the
content of the socket to a buffer.

Additional Description: See envoyproxy#17395
Risk Level: Medium
Testing: Automated
Docs Changes: Pending
Release Notes: Pending
Platform Specific Features: Windows only

Co-authored-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    @soulxu
    Sotiris Nanopoulos and soulxu committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    fa5a289 View commit details
    Browse the repository at this point in the history

  2. fix format 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    c2b5b44 View commit details
    Browse the repository at this point in the history

  3. fix compiler warning 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    fd85009 View commit details
    Browse the repository at this point in the history

  4. fix compilation issue 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    8972610 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. more coverage is needed but still testing ci 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    4aeaeae View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into peekWindows2

    Sotiris Nanopoulos committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    544a1c8 View commit details
    Browse the repository at this point in the history

  3. fix format and increase coverage 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    15fc820 View commit details
    Browse the repository at this point in the history

  4. fix format 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    4e60815 View commit details
    Browse the repository at this point in the history

  5. fix gcc 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    fe11b35 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. address PR feedack v1 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    1534dcd View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. address comments 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    3eb8880 View commit details
    Browse the repository at this point in the history

  2. fix spelling 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    f2fd1fb View commit details
    Browse the repository at this point in the history

  3. fix format 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    72e8f20 View commit details
    Browse the repository at this point in the history

  4. add override keyword 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    db35fbf View commit details
    Browse the repository at this point in the history

  5. another format fix 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    16caa4f View commit details
    Browse the repository at this point in the history

  6. fix string buffer used in fuzzing 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    a479ef8 View commit details
    Browse the repository at this point in the history

  7. fix typo in fuzzer 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    d3dd4d3 View commit details
    Browse the repository at this point in the history

  8. add override keyword 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    23c6341 View commit details
    Browse the repository at this point in the history

  9. fixed another typo 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    1c1223f View commit details
    Browse the repository at this point in the history

  10. remove unused parameters 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    abe8be2 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. PR comments and tests 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    31aee37 View commit details
    Browse the repository at this point in the history

  2. add hint for mac compiler 

    Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
    Sotiris Nanopoulos committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    55361a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Improve the copyOutToSlices method 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    320e370 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into peekWindows2 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    f73213d View commit details
    Browse the repository at this point in the history

  3. address comment 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    a2e8799 View commit details
    Browse the repository at this point in the history

  4. type conversion for macos 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    d113f4c View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2021

  1. correct the copyOutToSlices method 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    0c03750 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into peekWindows2 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    52828ee View commit details
    Browse the repository at this point in the history

  3. remove NOT_IMPLEMENTED_GCOVR_EXCL_LINE 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    959170b View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Merge branch 'main' into peekWindows2 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    d023827 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. address comment 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    d2fe6e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into peekWindows2 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    d673110 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. address comment 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    fc5b188 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into peekWindows2 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    9ab00eb View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Merge branch 'main' into peekWindows2 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    c100290 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Merge branch 'main' into peekWindows2 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    9ff8188 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Fix the peek size 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a8db58b View commit details
    Browse the repository at this point in the history

  2. Add fuzz test for copyOutToSlices 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    88311b1 View commit details
    Browse the repository at this point in the history

  3. fix format 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    84d3b81 View commit details
    Browse the repository at this point in the history

  4. address comments 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    8b4acf3 View commit details
    Browse the repository at this point in the history

  5. address comment 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    7792871 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into peekWindows2 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    843ca3c View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Merge branch 'main' into peekWindows3 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    4bf0aff View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. fix copyOutToSlices 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    cf83aad View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. remove useless log 

    Signed-off-by: He Jie Xu <hejie.xu@intel.com>
    @soulxu
    soulxu committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    d789aae View commit details
    Browse the repository at this point in the history