Add connection timing stats for http1/http2 connection pools. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +129,8 @@ void ConnPoolImpl::onConnectionEvent(ActiveClient& client, uint32_t events) { | |||
| if (client.closed_with_active_rq_) { | |||
| checkForDrained(); | |||
| } | |||
| } else if (events & Network::ConnectionEvent::Connected) { | |||
There was a problem hiding this comment.
I would do this in its own if block
|
need tests @roman: timings are tricky with IsolatedStatsStore. Will add new one as discussed offline. |
mattklein123
approved these changes
Nov 15, 2016
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Oct 10, 2019
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
liuxu623
pushed a commit
to liuxu623/envoy
that referenced
this pull request
Jul 14, 2020
…proxy#222) Commit Message: //test/integration:protocol_integration_test After: Stats over 50 runs: max = 11.8s, min = 1.2s, avg = 4.0s, dev = 4.3s Before: Stats over 50 runs: max = 2.6s, min = 1.4s, avg = 2.4s, dev = 0.3s Signed-off-by: Yuchen Dai silentdai@gmail.com Additional Description: Risk Level: LOW Testing: test Docs Changes: n/a Release Notes: n/a Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
pushed a commit
that referenced
this pull request
Sep 29, 2020
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
zh-translation:docs/root/install/building.rst
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Updating Envoy to include #7453 (and subsequently libevent/libevent#849), which should fix the performance issues we're seeing on iOS. Resolves envoyproxy/envoy-mobile#215. Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Updating Envoy to include #7453 (and subsequently libevent/libevent#849), which should fix the performance issues we're seeing on iOS. Resolves envoyproxy/envoy-mobile#215. Signed-off-by: JP Simard <jp@jpsim.com>
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.