Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: forces groupadd to do not fail when group already exists #2422

Merged
merged 1 commit into from
Jan 21, 2018

Conversation

gsagula
Copy link
Member

@gsagula gsagula commented Jan 21, 2018

Description: This PR fixes #2379 by passing force to docker command. This option causes the command to exit with success status if the specified group already exists.

Risk Level: Low

Testing: manual OsX

Signed-off-by: Gabriel gsagula@gmail.com

Signed-off-by: Gabriel <gsagula@gmail.com>
@gsagula
Copy link
Member Author

gsagula commented Jan 21, 2018

@htuch That mitigates the problem for OSx, but I think it's not quite right. I can look at this again tomorrow.

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@htuch htuch merged commit d076db6 into envoyproxy:master Jan 21, 2018
@gsagula gsagula deleted the run_envoy_docker_fix branch April 14, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants