health checker: removing exceptions #27859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssawilk
force-pushed
the
e_health_checks
branch
4 times, most recently
from
009c357
to
262cf51
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
e_health_checks
branch
from
262cf51
to
142c527
Compare
adisuissa
approved these changes
Jun 15, 2023
| throw_action EnvoyException(std::string(variable.status().message())); \ | ||
| } | ||
|
|
||
| #define RETURN_IF_STATUS_NOT_OK(variable) \ |
There was a problem hiding this comment.
nit: probably not really related to exceptions, so perhaps move to another file in the future.
asheryerm
pushed a commit
to asheryerm/envoy
that referenced
this pull request
Jul 5, 2023
Risk Level: medium Testing: new tests Docs Changes: n/a Release Notes: n/a Part of envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: asheryer <asheryer@amazon.com>
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
Risk Level: medium Testing: new tests Docs Changes: n/a Release Notes: n/a Part of envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: medium
Testing: new tests
Docs Changes: n/a
Release Notes: n/a
Part of envoyproxy/envoy-mobile#176