Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hcm router fuzzer: call correct fromHeaders implementation #28096

Merged
merged 1 commit into from
Jun 26, 2023
Merged

hcm router fuzzer: call correct fromHeaders implementation #28096

merged 1 commit into from
Jun 26, 2023

Conversation

robertfemmer
Copy link
Contributor

I forgot to switch one call to the correct fromHeaders implementation that will not debug assert when faced with invalid headers. This PR fixes the call otherwise leading to noise in oss-fuzz.

Signed-off-by: Robert Femmer <robert.femmer@x41-dsec.de>
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa adisuissa merged commit 020de5c into envoyproxy:main Jun 26, 2023
@robertfemmer robertfemmer deleted the hcm_router_fuzzer_fix branch June 28, 2023 09:48
asheryerm pushed a commit to asheryerm/envoy that referenced this pull request Jul 5, 2023
…y#28096)

Signed-off-by: Robert Femmer <robert.femmer@x41-dsec.de>
Signed-off-by: asheryer <asheryer@amazon.com>
reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023
…y#28096)

Signed-off-by: Robert Femmer <robert.femmer@x41-dsec.de>
Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants