[balsa] Validate trailers even if not enabled. #28958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings BalsaParser trailer validation (format and characters) in alignment with http-parser behavior. The downside is that this change makes BalsaParser enforce the header size limit (both on individual lines and on total size of trailer block) even when trailers are not enabled, whereas http-parser does not restrict size at all when trailers are not enabled. Signed-off-by: Bence Béky <bnc@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings BalsaParser trailer validation (format and characters) in alignment with http-parser behavior. The downside is that this change makes BalsaParser enforce the header size limit (both on individual lines and on total size of trailer block) even when trailers are not enabled, whereas http-parser does not restrict size at all when trailers are not enabled.
Tracking issue: #21245
Signed-off-by: Bence Béky bnc@google.com
Commit Message: [balsa] Validate trailers even if not enabled.
Additional Description:
Risk Level: low, changed code protected by existing default-false runtime flag.
Testing: //test/common/http/http1:codec_impl_test
Release Notes: n/a
Platform Specific Features: n/a
Runtime guard: envoy.reloadable_features.http1_use_balsa_parser