Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang/tidy: Fixes (the rest) #29660

Merged
merged 4 commits into from
Sep 28, 2023
Merged

clang/tidy: Fixes (the rest) #29660

merged 4 commits into from
Sep 28, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 16, 2023

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft September 16, 2023 18:04
@phlax
Copy link
Member Author

phlax commented Sep 16, 2023 •
edited
Loading

cc @wbpcode this gets the codebase (except mobile and a broken tool) passing clang-tidy

im not sure about some of the fixes so it will need to be checked carefully

anything i was particularly unsure about, i used a NOLINT

some of these may be flagging important things so these probably need to be checked even more carefully i think

@phlax phlax force-pushed the clang-tidy-code-fixes branch 3 times, most recently from f0e2219 to e5a8d21 Compare September 16, 2023 20:23
@phlax phlax force-pushed the clang-tidy-code-fixes branch 7 times, most recently from 687d71a to 1c65bed Compare September 17, 2023 12:23
@phlax phlax changed the title [WIP] clang/tidy: Fixes [WIP] clang/tidy: Fixes (the rest) Sep 17, 2023
@phlax
Copy link
Member Author

phlax commented Sep 17, 2023

separating out PRs for source/contrib/test

@phlax phlax force-pushed the clang-tidy-code-fixes branch 2 times, most recently from b1119d9 to 5e002d7 Compare September 19, 2023 08:29
@phlax phlax force-pushed the clang-tidy-code-fixes branch 2 times, most recently from 2a429c6 to 3b8bc4f Compare September 20, 2023 13:58
@phlax
Copy link
Member Author

phlax commented Sep 21, 2023

/retest (testing)

@phlax
Copy link
Member Author

phlax commented Sep 21, 2023

/retest testing

1 similar comment
@phlax
Copy link
Member Author

phlax commented Sep 21, 2023

/retest testing

@phlax phlax force-pushed the clang-tidy-code-fixes branch 3 times, most recently from bbc4b76 to 20f1afd Compare September 22, 2023 12:25
@phlax phlax changed the title [WIP] clang/tidy: Fixes (the rest) clang/tidy: Fixes (the rest) Sep 22, 2023
@phlax phlax marked this pull request as ready for review September 22, 2023 12:26
@phlax
Copy link
Member Author

phlax commented Sep 22, 2023

@wbpcode this contains the remaining fixes/etc - a lot of NOLINT as its mostly issues i was less clear how to resolve

with the help of @ravenblackx ive managed to improve some of the fixes, but it would be good to remove more nolints - happy to iterate this before we land to get fixes right

@phlax phlax force-pushed the clang-tidy-code-fixes branch from 20f1afd to 022022e Compare September 22, 2023 12:37
wbpcode
wbpcode reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@wbpcode wbpcode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. only one question.

.clang-tidy Outdated Show resolved Hide resolved
wbpcode
wbpcode previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. We add lots of NOLINT to the code base. But I think it is ok. The main responsibility of this PR is fix the CI rather than to improve the code quality. The last one could be achieved gradually by all contributors' work.

envoy/stats/refcount_ptr.h
@@ -115,7 +116,7 @@ template <class T> class RefcountPtr {
// forth.
#if __cplusplus < 202002L
template <class T> static bool operator==(std::nullptr_t, const RefcountPtr<T>& a) {
return a == nullptr;
return a == nullptr; // NOLINT(clang-analyzer-cplusplus.Move)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, why this line need this nolint...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea tbh - but confirmed its necessary

./envoy/stats/refcount_ptr.h:119:10: error: Method called on moved-from object 'rp4' [clang-analyzer-cplusplus.Move,-warnings-as-errors]
  return a == nullptr;
         ^

https://dev.azure.com/cncf/envoy/_build/results?buildId=150324&view=logs&j=b7634614-24f3-5416-e791-4f3affaaed6c&t=d565ee52-b888-5d80-7fea-dfaed104c390&l=35

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also don't know why, orz.

@wbpcode
Copy link
Member

wbpcode commented Sep 27, 2023 •
edited
Loading

re to the coverage failure, seems the new nolint comments changed the coverage calculating result.

If you think it's OK, I could try to create a patch to your branch to update the code and avoid the nolint comments in the quic directory.
cc @phlax

@phlax
Copy link
Member Author

phlax commented Sep 27, 2023

If you think it's OK, I could try to create a patch to your branch to update the code and avoid the nolint

that would be amazing

phlax and others added 4 commits September 27, 2023 07:05
@phlax
clang/tidy: Fixes
c548853 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
assisted-fixes
f4675ce 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
fixes
373c052 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
resolve clang-tidy issue of quic
138e970 
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the clang-tidy-code-fixes branch from 3cb1747 to 138e970 Compare September 27, 2023 06:05
wbpcode
wbpcode approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@phlax phlax merged commit 38dec86 into envoyproxy:main Sep 28, 2023
115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbpcode wbpcode wbpcode approved these changes

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

@alyssawilk alyssawilk Awaiting requested review from alyssawilk alyssawilk is a code owner

@ravenblackx ravenblackx Awaiting requested review from ravenblackx

@zuercher zuercher Awaiting requested review from zuercher

@yanavlasov yanavlasov Awaiting requested review from yanavlasov

@ggreenway ggreenway Awaiting requested review from ggreenway ggreenway is a code owner

@soulxu soulxu Awaiting requested review from soulxu

@KBaichoo KBaichoo Awaiting requested review from KBaichoo

@kyessenov kyessenov Awaiting requested review from kyessenov kyessenov is a code owner

@lizan lizan Awaiting requested review from lizan

@jmarantz jmarantz Awaiting requested review from jmarantz

@htuch htuch Awaiting requested review from htuch

Assignees

@wbpcode wbpcode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phlax @wbpcode