otlp_stats_sink: Fix otlp histogram buckets #31197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ohadvano <ohadvano@gmail.com>
|
Hi, @jmarantz, could you please do a first pass on this PR? |
jmarantz
previously approved these changes
Dec 7, 2023
|
Thanks @ohadvano! This looks correct to me |
Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com>
Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com>
mattklein123
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Description: Fixes #31016. The flushed histogram "count" did not match the bucket counts. Two fixes were required - the bucket counts are disjointed, i.e. do not take the previous bucket count into consideration, additional bucket is added to indicate the count of values outside the explicit bounds of the histogram, i.e. to +inf.
Risk Level: medium
Testing: unit tests
Docs Changes: none
Release Notes: none
Platform Specific Features: none