Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add %UPSTREAM_CLUSTER_RAW% formatter #35265

Merged
merged 6 commits into from
Jul 24, 2024

Merge branch 'main' into formatter/raw-cluster-name

3fca89c
Select commit
Loading
Failed to load commit list.
Merged

Add %UPSTREAM_CLUSTER_RAW% formatter #35265

Merge branch 'main' into formatter/raw-cluster-name
3fca89c
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/ASAN skipped Jul 24, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/35265/main@3fca89c)

keithmattix @keithmattix 3fca89c #35265 merge main@8a214e8

Add %UPSTREAM_CLUSTER_RAW% formatter

The %UPSTREAM_CLUSTER% formatter is affected by alt_stat_name, but there are times where a custom stat name may have special delimeters meant to help with stat tag regex parsing but those delimeters shouldn't show up in access logs. In these cases, %RAW_UPSTREAM_CLUSTER% could be used.

Commit Message: Add %RAW_UPSTREAM_CLUSTER% access log formatter
Additional Description:
Risk Level: no
Testing: unit
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Environment

Request variables

Key Value
ref ef2c7d4
sha 3fca89c
pr 35265
base-sha 8a214e8
actor keithmattix @keithmattix
message Add %UPSTREAM_CLUSTER_RAW% formatter...
started 1721795255.658214
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true