quic: remove server-preferred-address config WIP status #35425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Greenway <ggreenway@apple.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
@danzh2010 and @RyanTheOptimist the comment says to discuss before removing the WIP status, so what do you guys think? |
|
This sounds fine to me. From the comment it sounds like we should ping API shepherds? |
|
/wait |
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
RyanTheOptimist
approved these changes
Jul 30, 2024
|
I'm assuming that signoff from @abeyad should be sufficient consent from api-shepherds. And we're 2.5 months from the next release, so if anyone feels strongly about this, we can revert. |
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
…5425) These configs have been around for a few releases, and seem to be stable. Removing this status so that Envoy no longer warns when they are used. Signed-off-by: Greg Greenway <ggreenway@apple.com> Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
…5425) These configs have been around for a few releases, and seem to be stable. Removing this status so that Envoy no longer warns when they are used. Signed-off-by: Greg Greenway <ggreenway@apple.com> Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: These configs have been around for a few releases, and seem to be stable. Removing this status so that Envoy no longer warns when they are used.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]