Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redis_proxy] Add support for SELECT and KEYS #37706

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

duanhongyi
Copy link
Contributor

This RP mainly improves the compatibility of redis proxy, improvement as follows:

  • Add support for the select command, referring to the implementation of Apache KVRocks and Microsoft Garnet, simply returns OK.
  • Add keys command support, send keys commands to each shard on the backend, and then merge the results.
  • For unsupport commands, the return value is the same as Redis, because some clients judge this return value, for example, Java lettuce client

Copy link

Hi @duanhongyi, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #37706 was opened by duanhongyi.

see: more, trace.

@duanhongyi duanhongyi force-pushed the main branch 5 times, most recently from 8585977 to 2d6baa7 Compare December 18, 2024 11:42
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assigning @weisisea @mattklein123 as codeowners
/assign @weisisea @mattklein123

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a high level. Can you fix the typo comments and then push to see if we can get CI green?

/wait

@duanhongyi
Copy link
Contributor Author

duanhongyi commented Dec 19, 2024

I rebased the last commit, mainly to solve the compatibility issues of the Java client.

@mattklein123

@duanhongyi duanhongyi force-pushed the main branch 6 times, most recently from 8af3e65 to 488fcda Compare December 20, 2024 10:30
@duanhongyi
Copy link
Contributor Author

duanhongyi commented Dec 20, 2024

There is still one that hasn't turned green, I will add some test cases later.

Code coverage for source/extensions/filters/network/redis_proxy is lower than limit of 96.6 (95.5)

@duanhongyi duanhongyi force-pushed the main branch 2 times, most recently from 85b3e73 to 7fb8c98 Compare December 21, 2024 13:17
Signed-off-by: duanhongyi <duanhongyi@doopai.com>
Signed-off-by: duanhongyi <duanhongyi@doopai.com>
Signed-off-by: duanhongyi <duanhongyi@doopai.com>
@duanhongyi
Copy link
Contributor Author

Okay, all the checks have been passed.

@mattklein123

@mattklein123 mattklein123 merged commit 712b736 into envoyproxy:main Dec 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants