Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network utility getoriginaldst for IPv6 #3933

Merged
merged 3 commits into from
Jul 24, 2018

Conversation

cmluciano
Copy link
Member

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

title: Update network utility getoriginaldst for IPv6

Description:
This PR adds IP6T_SO_ORIGINAL_DST to the network utility for retaining the original_dest.

Risk Level:
Medium: Because we have to hardcode this with a define, there is a risk that upstream this gets changed and we would have to adjust. The define is necessary without the unmerged patch from Oct 2016. The TLDR is that the C code does not compile well with our compiler as shown here.

Testing:
Current tests exist

Docs Changes:
In progress

Release Notes:
Support IPv6 for original_dest in network utility

Fixes #1094

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
@cmluciano
Copy link
Member Author

cc @htuch here is the PR to replace #3630

fingers crossed that DCO doesn't flake

Christopher M. Luciano added 2 commits July 23, 2018 19:30
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for routing around the DCO issue.

@htuch htuch merged commit 0a43ae8 into envoyproxy:master Jul 24, 2018
@cmluciano cmluciano deleted the cml/ipv6dst branch July 24, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants