Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix envoy-filter-example build #3947

Merged
merged 1 commit into from
Jul 24, 2018
Merged

build: Fix envoy-filter-example build #3947

merged 1 commit into from
Jul 24, 2018

Conversation

sesmith177
Copy link
Member

Description:
Some of the references to "//bazel:windows_x86_64" were not properly prefixed with the repostory name, causing the build of envoy-filter-example to fail.

Risk Level:
Low
Testing:
bazel test //test/...
From envoy-filter-example, ran bazel build //:envoy
Docs Changes:
Release Notes:

Some of the references to "//bazel:windows_x86_64" were not properly
prefixed with the repostory name, causing the build of
envoy-filter-example to fail.

Signed-off-by: Sam Smith <sesmith177@gmail.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@rgs1
Copy link
Member

rgs1 commented Jul 24, 2018

lgtm, thanks!

@htuch htuch merged commit a03c343 into envoyproxy:master Jul 24, 2018
@sesmith177 sesmith177 deleted the fix-filter-windows branch October 5, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants