Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: remove unused variables #4013

Merged
merged 1 commit into from
Aug 1, 2018
Merged

stats: remove unused variables #4013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions source/common/stats/thread_local_store.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,12 @@ std::vector<GaugeSharedPtr> ThreadLocalStoreImpl::gauges() const {
}

std::vector<ParentHistogramSharedPtr> ThreadLocalStoreImpl::histograms() const {
// Handle de-dup due to overlapping scopes.
std::vector<ParentHistogramSharedPtr> ret;
std::unordered_set<std::string> names;
Thread::LockGuard lock(lock_);
// TODO(ramaraochavali): As histograms don't share storage, there is a chance of duplicate names
// here. We need to create global storage for histograms similar to how we have a central storage
// in shared memory for counters/gauges. In the interim, no de-dup is done here. This may result
// in histograms with duplicate names, but until shared storage is implementing it's ultimately
// in histograms with duplicate names, but until shared storage is implemented it's ultimately
// less confusing for users who have such configs.
for (ScopeImpl* scope : scopes_) {
for (const auto& name_histogram_pair : scope->central_cache_.histograms_) {
Expand Down