api: limit regexes to 1024 chars. #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids stack overflow in libc++ regex parsing libraries. There doesn't seem to be a good reason to support arbitrary long regexes in Envoy in general. Discovered by oss-fuzz, resolves ClusterFuzz issues https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8060 and https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8950. Risk level: Low Testing: Added corpus entry. Signed-off-by: Harvey Tuch <htuch@google.com>
danielhochman
previously approved these changes
Aug 20, 2018
|
lgtm. should we add a note somewhere in the docs so that a blame on this PR is not the only point of reference for the constraint? |
Signed-off-by: Harvey Tuch <htuch@google.com>
danielhochman
approved these changes
Aug 20, 2018
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Aug 21, 2018
I missed this one in envoyproxy#4198, this fixes oss-fuzz issue https://oss-fuzz.com/v2/testcase-detail/5085445791678464. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
that referenced
this pull request
Aug 21, 2018
I missed this one in #4198, this fixes oss-fuzz issue https://oss-fuzz.com/v2/testcase-detail/5085445791678464. Signed-off-by: Harvey Tuch <htuch@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids stack overflow in libc++ regex parsing libraries. There doesn't seem to be a good reason
to support arbitrary long regexes in Envoy in general.
Discovered by oss-fuzz, resolves ClusterFuzz issues
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8060 and
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8950.
Risk level: Low
Testing: Added corpus entry.
Signed-off-by: Harvey Tuch htuch@google.com