fuzz: make temporary path and port handling less flaky for server fuz… #4202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…z tests. * Avoid reusing temporary paths across tests. * Force port zero binding on server_fuzz_test. * Force server_fuzz_test not to write access log to random places on FS. I don't think this is the last we'll see on the server_fuzz_test flake test, since this particular fuzz test is inherently non-hermetic. So, this seems to be the high payoff whackamole for now. Risk level: Low. Testing: Ran server_fuzz_test test under Bazel and oss-fuzz Docker image. Signed-off-by: Harvey Tuch <htuch@google.com>
dnoe
reviewed
Aug 20, 2018
test/fuzz/fuzz_runner.h
Outdated
| std::string temporaryPath(const std::string& path) const { return test_tmpdir_ + "/" + path; } | ||
|
|
||
| private: | ||
| std::string test_tmpdir_; |
There was a problem hiding this comment.
nit: You could make test_tmpdir_ const and initialize in the ctor initializer list:
PerTestEnvironment::PerTestEnvironment() : test_tmpdir_([](){
const std::string fuzz_path = TestEnvironment::temporaryPath("fuzz_XXXXXX");
char test_tmpdir[fuzz_path.size() + 1];
StringUtil::strlcpy(test_tmpdir, fuzz_path.data(), fuzz_path.size() + 1);
RELEASE_ASSERT(::mkdtemp(test_tmpdir) != nullptr, "");
return std::string(test_tmpdir);
}()) {}
There was a problem hiding this comment.
I've had people point out to me in the past that this makes C++ look like JavaScript spaghetti, but sure, why not :)
test/server/server_fuzz_test.cc
Outdated
| makeHermeticPathsAndPorts(Fuzz::PerTestEnvironment& test_env, | ||
| const envoy::config::bootstrap::v2::Bootstrap& input) { | ||
| envoy::config::bootstrap::v2::Bootstrap output; | ||
| output.MergeFrom(input); |
There was a problem hiding this comment.
Why not just envoy::config::bootstrap::v2::Bootstrap output(input) to get the initial state? Isn't this equivalent?
dnoe
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…z tests.
Avoid reusing temporary paths across tests.
Force port zero binding on server_fuzz_test.
Force server_fuzz_test not to write access log to random places on FS.
I don't think this is the last we'll see on the server_fuzz_test flake test, since this particular
fuzz test is inherently non-hermetic. So, this seems to be the high payoff whackamole for now.
Risk level: Low.
Testing: Ran server_fuzz_test test under Bazel and oss-fuzz Docker image.
Signed-off-by: Harvey Tuch htuch@google.com