ci: Copy WORKSPACE for api build #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony Allen <tallen@lyft.com>
tonya11en
changed the title
|
Looks like the API build is passing, but I'm not sure how we can verify this is a 100% fix. I'm open to any suggestions. |
htuch
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
@tonya11en thanks. Let's merge and see if this fixes data-plane-api, if you could manually verify it would be great.
|
In line with recent PRs that changed most of the dependencies that can leverage releases to sha256 validated downloads I was about to submit the following. Any concerns about this approach @htuch -GOGOPROTO_SHA = "1adfc126b41513cc696b209667c8656ea7aac67c" # v1.0.0
+GOGOPROTO_RELEASE = "1.1.1"
+GOGOPROTO_SHA256 = "9f8c2ad49849ab063cd9fef67e77d49606640044227ecf7f3617ea2c92ef147c"
- strip_prefix = "protobuf-" + GOGOPROTO_SHA,
- url = "https://github.com/gogo/protobuf/archive/" + GOGOPROTO_SHA + ".tar.gz",
+ sha256 = GOGOPROTO_SHA256,
+ strip_prefix = "protobuf-" + GOGOPROTO_RELEASE,
+ url = "https://github.com/gogo/protobuf/archive/v" + GOGOPROTO_RELEASE + ".tar.gz", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
CI for data-plane-api has been failing since gogoproto was updated at envoyproxy/data-plane-api@43bc9ad. This patch makes it so that we also copy over the entirety of the WORKSPACE.
I am creating this PR so I can test if the CI passes successfully.
Risk Level:
Low
Testing:
Running CI in PR.
Fixes #4218