Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add level/edge trigger param to FileEventImpl and DispatcherImpl::cre… #456

Merged
merged 2 commits into from
Feb 10, 2017
Merged

Add level/edge trigger param to FileEventImpl and DispatcherImpl::cre… #456

merged 2 commits into from
Feb 10, 2017

Conversation

htuch
Copy link
Member

@htuch htuch commented Feb 9, 2017

…ateFileEvent().

c-ares needs level triggering (#143).

mattklein123
mattklein123 reviewed Feb 10, 2017
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. For the DNS stuff, are you going to need the ability to disable the events? Or are you planning on just deleting and recreating the event? If you need to disable/enable do you want to add that in this PR as well?

@htuch
Copy link
Member Author

htuch commented Feb 10, 2017

Yeah, was going to split that of as a separate change, but here it is.

mattklein123
mattklein123 approved these changes Feb 10, 2017
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks

@mattklein123 mattklein123 merged commit 71ee2f6 into envoyproxy:master Feb 10, 2017
@htuch htuch deleted the level-trigger branch February 10, 2017 19:07
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
@mtakigiku @qiwzhang
jwt-auth: make audiences configurable for each issuer (envoyproxy#456)
53f299a 
* make audiences configurable for each issuer

* audience -> audiences

* change function name and use std::find()
jplevyak added a commit to jplevyak/envoy that referenced this pull request Apr 13, 2020
@jplevyak
Backport: get vm_configuration from base_wasm if available. (envoypro…
2ee431d 
…xy#456)

Signed-off-by: John Plevyak <jplevyak@gmail.com>
wolfguoliang pushed a commit to wolfguoliang/envoy that referenced this pull request Jan 23, 2021
@yoyochan7253
zh-translation: https://github.com/cloudnativeto/envoy/blob/zh/docs/r…
60db2c2 
…oot/configuration/http/http_filters/cdn_loop_filter.rst (envoyproxy#456)
jpsim pushed a commit that referenced this pull request Nov 28, 2022
@junr03 @jpsim
core: expose stream options (#520)
0593190 
Description: after a bit more discussion we have decided to go ahead and make buffering configurable. This PR revives #456
Risk Level: med - adds new surface area to the API
Testing: local apps and CI

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
@junr03 @jpsim
core: expose stream options (#520)
76d0706 
Description: after a bit more discussion we have decided to go ahead and make buffering configurable. This PR revives #456
Risk Level: med - adds new surface area to the API
Testing: local apps and CI

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htuch @mattklein123