Revert "c-ares DnsResolverImpl implementation (issue #143)." #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* check exp claim * use chrono::system_clock * remove unnecesarry include
jplevyak
added a commit
to jplevyak/envoy
that referenced
this pull request
Apr 13, 2020
Use ClusterInfo from streaminfo to get clustername too
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
…tener_filters.rst (envoyproxy#462)
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Adds an implementation of observing reachability on iOS which calls in to the function added in envoyproxy/envoy-mobile#443 to notify Envoy of a change in preferred network selection. Note that since the core maintains a singleton ref to the preferred network, these observations are also static and are not discarded. This should be addressed as part of implementing shutdown functionality in envoyproxy/envoy-mobile#445. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Adds an implementation of observing reachability on iOS which calls in to the function added in envoyproxy/envoy-mobile#443 to notify Envoy of a change in preferred network selection. Note that since the core maintains a singleton ref to the preferred network, these observations are also static and are not discarded. This should be addressed as part of implementing shutdown functionality in envoyproxy/envoy-mobile#445. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #428
cc @htuch