lint: remove unnecessary calls to std::string::c_str() and std::string::data() and fix use after move #4971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zyfjeff <tianqian.zyf@alibaba-inc.com>
Signed-off-by: tianqian.zyf <tianqian.zyf@alibaba-inc.com>
Signed-off-by: zyfjeff <tianqian.zyf@alibaba-inc.com>
mattklein123
reviewed
Nov 6, 2018
zyfjeff
force-pushed
the
clang-tidy-checker
branch
from
c6e6d0b to
2ce8764
Compare
Signed-off-by: tianqian.zyf <tianqian.zyf@alibaba-inc.com>
|
@mattklein123 can you PTAL when you get time? |
jmarantz
previously approved these changes
Nov 10, 2018
|
You will need address the clang_tidy errors per CI. |
Signed-off-by: tianqian.zyf <tianqian.zyf@alibaba-inc.com>
zyfjeff
force-pushed
the
clang-tidy-checker
branch
from
64b0244 to
6a63131
Compare
Signed-off-by: zyfjeff <tianqian.zyf@alibaba-inc.com>
mattklein123
approved these changes
Nov 11, 2018
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…g::data() and fix use after move (envoyproxy#4971) Signed-off-by: zyfjeff <tianqian.zyf@alibaba-inc.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: lint: remove unnecessary calls to std::string::c_str() and std::string::data() and fix use after move
Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue] #4863
[Optional Deprecated:]