envoyproxy · htuch · Jan 27, 2019 · Jan 15, 2019 · Jan 15, 2019 · Jan 15, 2019
diff --git a/.clang-tidy b/.clang-tidy
@@ -1,7 +1,7 @@
-Checks:          'clang-diagnostic-*,clang-analyzer-*,abseil-*,bugprone-*,modernize-*,performance-*,readability-redundant-*,readability-braces-around-statements'
+Checks:          'clang-diagnostic-*,clang-analyzer-*,abseil-*,bugprone-*,modernize-*,performance-*,readability-redundant-*,readability-braces-around-statements,fuchsia-statically-constructed-objects'
 
 #TODO(lizan): grow this list, fix possible warnings and make more checks as error
-WarningsAsErrors: 'bugprone-assert-side-effect,modernize-make-shared,modernize-make-unique,readability-redundant-smartptr-get,readability-braces-around-statements,readability-redundant-string-cstr,bugprone-use-after-move'
+WarningsAsErrors: 'bugprone-assert-side-effect,modernize-make-shared,modernize-make-unique,readability-redundant-smartptr-get,readability-braces-around-statements,readability-redundant-string-cstr,bugprone-use-after-move,fuchsia-statically-constructed-objects'
 
 CheckOptions:
   - key:             bugprone-assert-side-effect.AssertMacros

diff --git a/source/common/grpc/google_grpc_creds_impl.cc b/source/common/grpc/google_grpc_creds_impl.cc
@@ -122,6 +122,7 @@ class DefaultGoogleGrpcCredentialsFactory : public GoogleGrpcCredentialsFactory
 /**
  * Static registration for the default Google gRPC credentials factory. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<DefaultGoogleGrpcCredentialsFactory, GoogleGrpcCredentialsFactory>
     default_google_grpc_credentials_registered_;
 

diff --git a/source/common/network/resolver_impl.cc b/source/common/network/resolver_impl.cc
@@ -41,6 +41,7 @@ class IpResolver : public Resolver {
 /**
  * Static registration for the IP resolver. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<IpResolver, Resolver> ip_registered_;
 
 InstanceConstSharedPtr resolveProtoAddress(const envoy::api::v2::core::Address& address) {

diff --git a/source/extensions/access_loggers/file/config.cc b/source/extensions/access_loggers/file/config.cc
@@ -69,6 +69,7 @@ FileAccessLogFactory::convertJsonFormatToMap(ProtobufWkt::Struct json_format) {
 /**
  * Static registration for the file access log. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<FileAccessLogFactory,
                                  Server::Configuration::AccessLogInstanceFactory>
     register_;

diff --git a/source/extensions/access_loggers/http_grpc/config.cc b/source/extensions/access_loggers/http_grpc/config.cc
@@ -49,6 +49,7 @@ std::string HttpGrpcAccessLogFactory::name() const { return AccessLogNames::get(
 /**
  * Static registration for the HTTP gRPC access log. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<HttpGrpcAccessLogFactory,
                                  Server::Configuration::AccessLogInstanceFactory>
     register_;

diff --git a/source/extensions/filters/http/buffer/config.cc b/source/extensions/filters/http/buffer/config.cc
@@ -46,6 +46,7 @@ BufferFilterFactory::createRouteSpecificFilterConfigTyped(
 /**
  * Static registration for the buffer filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<BufferFilterFactory,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/cors/config.cc b/source/extensions/filters/http/cors/config.cc
@@ -22,6 +22,7 @@ CorsFilterFactory::createFilter(const std::string& stats_prefix,
 /**
  * Static registration for the cors filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<CorsFilterFactory,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/dynamo/config.cc b/source/extensions/filters/http/dynamo/config.cc
@@ -23,6 +23,7 @@ DynamoFilterConfig::createFilter(const std::string& stat_prefix,
 /**
  * Static registration for the http dynamodb filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<DynamoFilterConfig,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/ext_authz/config.cc b/source/extensions/filters/http/ext_authz/config.cc
@@ -67,6 +67,7 @@ ExtAuthzFilterConfig::createRouteSpecificFilterConfigTyped(
 /**
  * Static registration for the external authorization filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<ExtAuthzFilterConfig,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/fault/config.cc b/source/extensions/filters/http/fault/config.cc
@@ -41,6 +41,7 @@ FaultFilterFactory::createRouteSpecificFilterConfigTyped(
 /**
  * Static registration for the fault filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<FaultFilterFactory,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/grpc_http1_bridge/config.cc b/source/extensions/filters/http/grpc_http1_bridge/config.cc
@@ -20,6 +20,7 @@ GrpcHttp1BridgeFilterConfig::createFilter(const std::string&,
 /**
  * Static registration for the grpc HTTP1 bridge filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<GrpcHttp1BridgeFilterConfig,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/grpc_json_transcoder/config.cc b/source/extensions/filters/http/grpc_json_transcoder/config.cc
@@ -35,6 +35,7 @@ Http::FilterFactoryCb GrpcJsonTranscoderFilterConfig::createFilterFactory(
 /**
  * Static registration for the grpc transcoding filter. @see RegisterNamedHttpFilterConfigFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<GrpcJsonTranscoderFilterConfig,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/grpc_web/config.cc b/source/extensions/filters/http/grpc_web/config.cc
@@ -19,6 +19,7 @@ Http::FilterFactoryCb GrpcWebFilterConfig::createFilter(const std::string&,
 /**
  * Static registration for the gRPC-Web filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<GrpcWebFilterConfig,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/gzip/config.cc b/source/extensions/filters/http/gzip/config.cc
@@ -23,6 +23,7 @@ Http::FilterFactoryCb GzipFilterFactory::createFilterFactoryFromProtoTyped(
 /**
  * Static registration for the gzip filter. @see NamedHttpFilterConfigFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<GzipFilterFactory,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/header_to_metadata/config.cc b/source/extensions/filters/http/header_to_metadata/config.cc
@@ -28,6 +28,7 @@ Http::FilterFactoryCb HeaderToMetadataConfig::createFilterFactoryFromProtoTyped(
 /**
  * Static registration for the header-to-metadata filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<HeaderToMetadataConfig,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/health_check/config.cc b/source/extensions/filters/http/health_check/config.cc
@@ -67,6 +67,7 @@ HealthCheckFilterConfig::createFilterFactory(const Json::Object& json_config,
 /**
  * Static registration for the health check filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<HealthCheckFilterConfig,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/ip_tagging/config.cc b/source/extensions/filters/http/ip_tagging/config.cc
@@ -27,6 +27,7 @@ Http::FilterFactoryCb IpTaggingFilterFactory::createFilterFactoryFromProtoTyped(
 /**
  * Static registration for the ip tagging filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<IpTaggingFilterFactory,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/jwt_authn/filter_factory.cc b/source/extensions/filters/http/jwt_authn/filter_factory.cc
@@ -53,6 +53,7 @@ FilterFactory::createFilterFactoryFromProtoTyped(const JwtAuthentication& proto_
 /**
  * Static registration for this jwt_authn filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<FilterFactory, Server::Configuration::NamedHttpFilterConfigFactory>
     register_;
 

diff --git a/source/extensions/filters/http/lua/config.cc b/source/extensions/filters/http/lua/config.cc
@@ -34,6 +34,7 @@ LuaFilterConfig::createFilterFactory(const Json::Object& json_config,
 /**
  * Static registration for the Lua filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<LuaFilterConfig,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/ratelimit/config.cc b/source/extensions/filters/http/ratelimit/config.cc
@@ -55,6 +55,7 @@ RateLimitFilterConfig::createFilterFactory(const Json::Object& json_config,
 /**
  * Static registration for the rate limit filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<RateLimitFilterConfig,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/rbac/config.cc b/source/extensions/filters/http/rbac/config.cc
@@ -31,6 +31,7 @@ RoleBasedAccessControlFilterConfigFactory::createRouteSpecificFilterConfigTyped(
 /**
  * Static registration for the RBAC filter. @see RegisterFactory
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<RoleBasedAccessControlFilterConfigFactory,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/http/router/config.cc b/source/extensions/filters/http/router/config.cc
@@ -37,6 +37,7 @@ RouterFilterConfig::createFilterFactory(const Json::Object& json_config,
 /**
  * Static registration for the router filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<RouterFilterConfig,
                                  Server::Configuration::NamedHttpFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/listener/original_dst/config.cc b/source/extensions/filters/listener/original_dst/config.cc
@@ -35,6 +35,7 @@ class OriginalDstConfigFactory : public Server::Configuration::NamedListenerFilt
 /**
  * Static registration for the original dst filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<OriginalDstConfigFactory,
                                  Server::Configuration::NamedListenerFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/listener/original_src/original_src_config_factory.cc b/source/extensions/filters/listener/original_src/original_src_config_factory.cc
@@ -29,6 +29,7 @@ ProtobufTypes::MessagePtr OriginalSrcConfigFactory::createEmptyConfigProto() {
 /**
  * Static registration for the original_src filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<OriginalSrcConfigFactory,
                                  Server::Configuration::NamedListenerFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/listener/proxy_protocol/config.cc b/source/extensions/filters/listener/proxy_protocol/config.cc
@@ -34,6 +34,7 @@ class ProxyProtocolConfigFactory : public Server::Configuration::NamedListenerFi
 /**
  * Static registration for the proxy protocol filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<ProxyProtocolConfigFactory,
                                  Server::Configuration::NamedListenerFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/listener/tls_inspector/config.cc b/source/extensions/filters/listener/tls_inspector/config.cc
@@ -36,6 +36,7 @@ class TlsInspectorConfigFactory : public Server::Configuration::NamedListenerFil
 /**
  * Static registration for the TLS inspector filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<TlsInspectorConfigFactory,
                                  Server::Configuration::NamedListenerFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/client_ssl_auth/config.cc b/source/extensions/filters/network/client_ssl_auth/config.cc
@@ -37,6 +37,7 @@ Network::FilterFactoryCb ClientSslAuthConfigFactory::createFilterFactoryFromProt
 /**
  * Static registration for the client SSL auth filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<ClientSslAuthConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/dubbo_proxy/config.cc b/source/extensions/filters/network/dubbo_proxy/config.cc
@@ -26,6 +26,7 @@ Network::FilterFactoryCb DubboProxyFilterConfigFactory::createFilterFactoryFromP
 /**
  * Static registration for the dubbo filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<DubboProxyFilterConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/dubbo_proxy/dubbo_protocol_impl.cc b/source/extensions/filters/network/dubbo_proxy/dubbo_protocol_impl.cc
@@ -123,6 +123,7 @@ class DubboProtocolConfigFactory : public ProtocolFactoryBase<DubboProtocolImpl>
 /**
  * Static registration for the Dubbo protocol. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<DubboProtocolConfigFactory, NamedProtocolConfigFactory> register_;
 
 } // namespace DubboProxy

diff --git a/source/extensions/filters/network/dubbo_proxy/hessian_deserializer_impl.cc b/source/extensions/filters/network/dubbo_proxy/hessian_deserializer_impl.cc
@@ -93,6 +93,7 @@ class HessianDeserializerConfigFactory : public DeserializerFactoryBase<HessianD
 /**
  * Static registration for the Hessian protocol. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<HessianDeserializerConfigFactory, NamedDeserializerConfigFactory>
     register_;
 

diff --git a/source/extensions/filters/network/echo/config.cc b/source/extensions/filters/network/echo/config.cc
@@ -40,6 +40,7 @@ class EchoConfigFactory : public Server::Configuration::NamedNetworkFilterConfig
 /**
  * Static registration for the echo filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<EchoConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/ext_authz/config.cc b/source/extensions/filters/network/ext_authz/config.cc
@@ -40,6 +40,7 @@ Network::FilterFactoryCb ExtAuthzConfigFactory::createFilterFactoryFromProtoType
 /**
  * Static registration for the external authorization filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<ExtAuthzConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/http_connection_manager/config.cc b/source/extensions/filters/network/http_connection_manager/config.cc
@@ -114,6 +114,7 @@ Network::FilterFactoryCb HttpConnectionManagerFilterConfigFactory::createFilterF
 /**
  * Static registration for the HTTP connection manager filter.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<HttpConnectionManagerFilterConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/mongo_proxy/config.cc b/source/extensions/filters/network/mongo_proxy/config.cc
@@ -55,6 +55,7 @@ MongoProxyFilterConfigFactory::createFilterFactory(const Json::Object& json_conf
 /**
  * Static registration for the mongo filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<MongoProxyFilterConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/ratelimit/config.cc b/source/extensions/filters/network/ratelimit/config.cc
@@ -58,6 +58,7 @@ RateLimitConfigFactory::createFilterFactory(const Json::Object& json_config,
 /**
  * Static registration for the rate limit filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<RateLimitConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/rbac/config.cc b/source/extensions/filters/network/rbac/config.cc
@@ -85,6 +85,7 @@ RoleBasedAccessControlNetworkFilterConfigFactory::createFilterFactoryFromProtoTy
 /**
  * Static registration for the RBAC network filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<RoleBasedAccessControlNetworkFilterConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/redis_proxy/config.cc b/source/extensions/filters/network/redis_proxy/config.cc
@@ -51,6 +51,7 @@ RedisProxyFilterConfigFactory::createFilterFactory(const Json::Object& json_conf
 /**
  * Static registration for the redis filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<RedisProxyFilterConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/sni_cluster/config.cc b/source/extensions/filters/network/sni_cluster/config.cc
@@ -31,6 +31,7 @@ ProtobufTypes::MessagePtr SniClusterNetworkFilterConfigFactory::createEmptyConfi
 /**
  * Static registration for the sni_cluster filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<SniClusterNetworkFilterConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/tcp_proxy/config.cc b/source/extensions/filters/network/tcp_proxy/config.cc
@@ -37,6 +37,7 @@ Network::FilterFactoryCb ConfigFactory::createFilterFactoryFromProtoTyped(
 /**
  * Static registration for the tcp_proxy filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<ConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/thrift_proxy/auto_protocol_impl.cc b/source/extensions/filters/network/thrift_proxy/auto_protocol_impl.cc
@@ -84,6 +84,7 @@ class AutoProtocolConfigFactory : public ProtocolFactoryBase<AutoProtocolImpl> {
 /**
  * Static registration for the auto protocol. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<AutoProtocolConfigFactory, NamedProtocolConfigFactory> register_;
 
 } // namespace ThriftProxy

diff --git a/source/extensions/filters/network/thrift_proxy/auto_transport_impl.cc b/source/extensions/filters/network/thrift_proxy/auto_transport_impl.cc
@@ -82,6 +82,7 @@ class AutoTransportConfigFactory : public TransportFactoryBase<AutoTransportImpl
 /**
  * Static registration for the auto transport. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<AutoTransportConfigFactory, NamedTransportConfigFactory> register_;
 
 } // namespace ThriftProxy

diff --git a/source/extensions/filters/network/thrift_proxy/binary_protocol_impl.cc b/source/extensions/filters/network/thrift_proxy/binary_protocol_impl.cc
@@ -408,6 +408,7 @@ class BinaryProtocolConfigFactory : public ProtocolFactoryBase<BinaryProtocolImp
 /**
  * Static registration for the binary protocol. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<BinaryProtocolConfigFactory, NamedProtocolConfigFactory> register_;
 
 class LaxBinaryProtocolConfigFactory : public ProtocolFactoryBase<LaxBinaryProtocolImpl> {
@@ -418,6 +419,7 @@ class LaxBinaryProtocolConfigFactory : public ProtocolFactoryBase<LaxBinaryProto
 /**
  * Static registration for the auto protocol. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<LaxBinaryProtocolConfigFactory, NamedProtocolConfigFactory>
     register_lax_;
 

diff --git a/source/extensions/filters/network/thrift_proxy/compact_protocol_impl.cc b/source/extensions/filters/network/thrift_proxy/compact_protocol_impl.cc
@@ -625,6 +625,7 @@ class CompactProtocolConfigFactory : public ProtocolFactoryBase<CompactProtocolI
 /**
  * Static registration for the binary protocol. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<CompactProtocolConfigFactory, NamedProtocolConfigFactory>
     register_;
 

diff --git a/source/extensions/filters/network/thrift_proxy/config.cc b/source/extensions/filters/network/thrift_proxy/config.cc
@@ -116,6 +116,7 @@ Network::FilterFactoryCb ThriftProxyFilterConfigFactory::createFilterFactoryFrom
 /**
  * Static registration for the thrift filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<ThriftProxyFilterConfigFactory,
                                  Server::Configuration::NamedNetworkFilterConfigFactory>
     registered_;

diff --git a/source/extensions/filters/network/thrift_proxy/filters/ratelimit/config.cc b/source/extensions/filters/network/thrift_proxy/filters/ratelimit/config.cc
@@ -48,6 +48,7 @@ RateLimitFilterConfig::createFilterFactoryFromProtoTyped(
 /**
  * Static registration for the rate limit filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<RateLimitFilterConfig,
                                  ThriftProxy::ThriftFilters::NamedThriftFilterConfigFactory>
     register_;

diff --git a/source/extensions/filters/network/thrift_proxy/framed_transport_impl.cc b/source/extensions/filters/network/thrift_proxy/framed_transport_impl.cc
@@ -53,6 +53,7 @@ class FramedTransportConfigFactory : public TransportFactoryBase<FramedTransport
 /**
  * Static registration for the framed transport. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<FramedTransportConfigFactory, NamedTransportConfigFactory>
     register_;
 

diff --git a/source/extensions/filters/network/thrift_proxy/header_transport_impl.cc b/source/extensions/filters/network/thrift_proxy/header_transport_impl.cc
@@ -312,6 +312,7 @@ class HeaderTransportConfigFactory : public TransportFactoryBase<HeaderTransport
 /**
  * Static registration for the header transport. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<HeaderTransportConfigFactory, NamedTransportConfigFactory>
     register_;
 

diff --git a/source/extensions/filters/network/thrift_proxy/router/config.cc b/source/extensions/filters/network/thrift_proxy/router/config.cc
@@ -24,6 +24,7 @@ ThriftFilters::FilterFactoryCb RouterFilterConfig::createFilterFactoryFromProtoT
 /**
  * Static registration for the router filter. @see RegisterFactory.
  */
+// NOLINTNEXTLINE(fuchsia-statically-constructed-objects)
 static Registry::RegisterFactory<RouterFilterConfig, ThriftFilters::NamedThriftFilterConfigFactory>
     register_;