Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use macro to register extensions #5716

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

lizan
Copy link
Member

@lizan lizan commented Jan 25, 2019

Signed-off-by: Lizan Zhou lizan@tetrate.io

Description:
From discussion in #5602.

Risk Level: Low
Testing: CI
Docs Changes:
Release Notes:

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
Copy link
Member Author

lizan commented Jan 25, 2019

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: release (failed build)

🐱

Caused by: a #5716 (comment) was created by @lizan.

see: more, trace.

@lizan lizan merged commit 25c672c into envoyproxy:master Jan 25, 2019
@lizan lizan deleted the registry_macro branch January 25, 2019 19:36
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Jan 31, 2019
*Description*:
From discussion in envoyproxy#5602.

*Risk Level*: Low
*Testing*: CI
*Docs Changes*:
*Release Notes*:

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

Signed-off-by: Lizan Zhou <lizan.j@gmail.com>
fredlas pushed a commit to fredlas/envoy that referenced this pull request Mar 5, 2019
*Description*:
From discussion in envoyproxy#5602.

*Risk Level*: Low
*Testing*: CI
*Docs Changes*:
*Release Notes*:

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants