api: add control plane identifier #5860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
htuch
previously approved these changes
Feb 6, 2019
| // An opaque control plane identifier that uniquely identifies an instance | ||
| // of control plane. This can be used to identify which control plane instance, | ||
| // the Envoy is connected to. | ||
| string identifier = 1; |
There was a problem hiding this comment.
Presumably if we want something more structured, we will add a Struct later?
There was a problem hiding this comment.
Yes. Right now I do not know what that structure would look like. So just added this
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
This PR adds API support required for envoyproxy#5770 . Once envoyproxy#5844 lands, I will output it using the text stat. Risk Level: Low Testing: N/A Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rama Chavali rama.rao@salesforce.com
Description: This PR adds API support required for #5770 . Once #5844 lands, I will output it using the text stat.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A