runtime: support bootstrap runtime configuration. #6759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a first step towards TDS, add support for proto/JSON representations of the runtime virtual file system and plumb this into bootstrap. "numerator" and "denominator" are now reserved keywords and can't be used in runtime keys; this simplifies parsing significantly. It is not expected that these are widely used, due to the difficulty of ensuring atomicity if representing fractions, but this is technically a runtime API breaking change. Risk level: Medium (due to the reserved word changes). Testing: Unit and server tests added. Part of envoyproxy#6708 Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
alyssawilk
reviewed
May 1, 2019
| EXPECT_EQ("world", loader_->snapshot().get("file2")); | ||
| EXPECT_EQ("thing", loader_->snapshot().get("some")); | ||
| EXPECT_EQ("thang", loader_->snapshot().get("other")); | ||
| // Admin overrides disk and bootstrap. |
There was a problem hiding this comment.
Is it admin, or latest takes? If there's a file reload, does it overwrite the admin overrides?
I think we can be more clear about this in tests and docs.
There was a problem hiding this comment.
Good point. It overrides as a layer, I've added a test to demonstrate this (and convince myself!).
mattklein123
requested changes
May 2, 2019
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards TDS, add support for proto/JSON representations of the runtime virtual file
system and plumb this into bootstrap.
"numerator" and "denominator" are now reserved keywords and can't be used in runtime keys; this
simplifies parsing significantly. It is not expected that these are widely used, due to the
difficulty of ensuring atomicity if representing fractions, but this is technically a runtime API
breaking change.
Risk level: Medium (due to the reserved word changes).
Testing: Unit and server tests added.
Part of #6708
Signed-off-by: Harvey Tuch htuch@google.com