clang-tidy: performance-noexcept-move-constructor #7393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
|
/retest |
|
🔨 rebuilding |
|
This is subtle. TIL |
|
hmm coverage keeps core-dumping, seemingly on
Not seeing anything on master relating to a "fix" for this, gonna give it one more retest, and if that fails will merge master. BTW is there a way to access the error log file from Circle CI? I haven't figured that out yet for looking at the exact error log. |
|
/retest |
|
🔨 rebuilding |
|
@derekargueta that test flake is fixed in #7361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
performance-noexcept-move-constructorchecks for move constructors that aren't declarednoexcept, the reason being that STL containers will use the copy constructor for operations likeemplace_backif the move constructor is not declarednoexceptdue to exception safety guarantees.http://www.hlsl.co.uk/blog/2017/12/1/c-noexcept-and-move-constructors-effect-on-performance-in-stl-containers
https://stackoverflow.com/a/32225460
Risk Level: low
Testing: existing
Docs Changes: N/A
Release Notes: N/A
Relates to #4863
Signed-off-by: Derek Argueta dereka@pinterest.com