Code

[router] Add SRDS configUpdate impl#7451

Code

Merged

htuch merged 71 commits intoenvoyproxy:masterenvoyproxy/envoy:masterfrom stevenzzzz:scoped-config-impl-refactorstevenzzzz/envoy:scoped-config-impl-refactorCopy head branch name to clipboardAug 22, 2019

+1,137-304

Commits

Commits on Jun 11, 2019

• add scope key-builder impl and test

  Show description for 6a3f13b
  stevenzzzz

  committed
  6a3f13b

• Merge branch 'master' into add-key-builder

  Show description for cc806d7
  stevenzzzz

  committed
  cc806d7

• fix typo

  Show description for bb55a44
  stevenzzzz

  committed
  bb55a44

Commits on Jun 12, 2019

• move impl code from header to cc file.

  Show description for 8d7b4da
  stevenzzzz

  committed
  8d7b4da

• add review fixes and unit test case for keybuidler

  Show description for 8bcddce
  stevenzzzz

  committed
  8bcddce

• clang-tidy fix

  Show description for b1d0d5c
  stevenzzzz

  committed
  b1d0d5c

• use expect_debug_death for assertion test

  Show description for 1007ee0
  stevenzzzz

  committed
  1007ee0

• fix failed test in opt mode

  Show description for 184ff2f
  stevenzzzz

  committed
  184ff2f

Commits on Jun 13, 2019

• add assert around addFragment and test, and a few review fix

  Show description for fe6b643
  stevenzzzz

  committed
  fe6b643

Commits on Jun 19, 2019

• Merge branch 'master' into add-key-builder

  Show description for fc98e56
  stevenzzzz

  committed
  fc98e56

Commits on Jun 20, 2019

• Merge branch 'master' into add-key-builder

  Show description for 951bd28
  stevenzzzz

  committed
  951bd28

Commits on Jun 21, 2019

• fix based on feedbacks

  Show description for 75718d9
  stevenzzzz

  committed
  75718d9

Commits on Jun 25, 2019

• fix nits

  Show description for d84839d
  stevenzzzz

  committed
  d84839d

• switch from constructing proto memeber by value(copy-elision) to more explicit constructing by moving

  Show description for 27ff0a3
  stevenzzzz

  committed
  27ff0a3

Commits on Jul 2, 2019

• refactor scoped config impl a little bit, andd SRDS config update impl

  Show description for 36a6e72
  stevenzzzz

  committed
  36a6e72

• Merge branch 'master' into scoped-config-impl-refactor

  Show description for 46e23f2
  stevenzzzz

  committed
  46e23f2

• fix typo

  Show description for 74038f4
  stevenzzzz

  committed
  74038f4

Commits on Jul 8, 2019

• fix srds integration test and add some more test on scopekey

  Show description for ff7ccdb
  stevenzzzz

  committed
  ff7ccdb

• Merge branch 'CLEAN' into scoped-config-impl-refactor

  Show description for 06bd690
  stevenzzzz

  committed
  06bd690

Commits on Jul 9, 2019

• save review fixes

  Show description for cf38720
  stevenzzzz

  committed
  cf38720

• add conflict detection for scope keys

  Show description for 5cad3ee
  stevenzzzz

  committed
  5cad3ee

Commits on Jul 12, 2019

• Review feedbacks fix, and some more changes to the config provider framework:

  Show description for 50e8fb5
  stevenzzzz

  committed
  50e8fb5

• Merge branch 'master' into scoped-config-impl-refactor

  Show description for ac65ba2
  stevenzzzz

  committed
  ac65ba2

• make SRDS the SotW onConfigUpdate API a quasi-incremental one per dicussino w/ htuch

  Show description for cb5324f
  stevenzzzz

  committed
  cb5324f

• fix clang-tidy bug

  Show description for 5c8a546
  stevenzzzz

  committed
  5c8a546

Commits on Jul 15, 2019

• revert the quasi-incremental delta onConfigUpdate change after offline discussion

  Show description for 4a1fb01
  stevenzzzz

  committed
  4a1fb01

• Merge branch 'CLEAN' into scoped-config-impl-refactor

  Show description for fdd0a74
  stevenzzzz

  committed
  fdd0a74

Commits on Jul 24, 2019

• refactor config provider framework

  Show description for 467a6a1
  stevenzzzz

  committed
  467a6a1

• some renames and stale comment fix

  Show description for 7dea1a0
  stevenzzzz

  committed
  7dea1a0

Commits on Jul 25, 2019

• merge PR envoyproxy#7704, add init_manager injection when creating RdsRouteConfigProvider

  Show description for c354a1e
  stevenzzzz

  committed
  c354a1e

• Merge branch 'master' of https://github.com/envoyproxy/envoy into add-key-builder

  Show description for 2b5f572
  stevenzzzz

  committed
  2b5f572

Commits on Jul 29, 2019

• fix a bug in update-propagation: new version should overwrite old version in per-thread config impl, and make sure the old copy always gets destructed in main thread

  Show description for 9dd4214
  stevenzzzz

  committed
  9dd4214

• make a ScopeRouteInfo owns a RouteConfigProvider, as per the config provider framework refactor, we will likely not have shared RouteConfigProvider instance but shared RouteConfigSubscription/Route…

  Show description for 5d2f8a2
  stevenzzzz

  committed
  5d2f8a2

Commits on Jul 30, 2019

• fixes for review feedbacks

  Show description for 86c455e
  stevenzzzz

  committed
  86c455e

• fix comment

  Show description for 60dd433
  stevenzzzz

  committed
  60dd433

• snowp comments

  Show description for 6c1a672
  stevenzzzz

  committed
  6c1a672

• Merge branch 'master' of https://github.com/envoyproxy/envoy into CLEAN

  Show description for c31de28
  stevenzzzz

  committed
  c31de28

• Merge branch 'master' into config-provider-update

  Show description for abfe558
  stevenzzzz

  committed
  abfe558

• merge main & config-provider-update into srds onConfigUpdate PR

  Show description for 69df754
  stevenzzzz

  committed
  69df754

• some cleanup around noop watcher

  Show description for 5f357bd
  stevenzzzz

  committed
  5f357bd

• fix-format

  Show description for dd3b97d
  stevenzzzz

  committed
  dd3b97d

Commits on Aug 1, 2019

• add more comment

  Show description for ee09a5b
  stevenzzzz

  committed
  ee09a5b

• fix typo, add back missing constructor in config_provider_test

  Show description for 46ad9af
  stevenzzzz

  committed
  46ad9af

• Merge branch 'master' of https://github.com/envoyproxy/envoy

  Show description for 47a417d
  stevenzzzz

  committed
  47a417d

• Merge branch 'master' of https://github.com/envoyproxy/envoy

  Show description for 9c1f616
  stevenzzzz

  committed
  9c1f616

• merge with upstream master

  Show description for ae2ac31
  stevenzzzz

  committed
  ae2ac31

• expect death when a null fragment is added into scopekey

  Show description for b1acd70
  stevenzzzz

  committed
  b1acd70

Commits on Aug 2, 2019

• fix per andres comments

  Show description for d08bdb2
  stevenzzzz

  committed
  d08bdb2

• fix pedant spelling check errors.

  Show description for eb65b89
  stevenzzzz

  committed
  eb65b89

• fix failing add null fragment assertion test. expect_death ==> expect_debug_death

  Show description for 07bdfee
  stevenzzzz

  committed
  07bdfee

• only death test in debug mode for add null fragment to scopeKey

  Show description for 40b214e
  stevenzzzz

  committed
  40b214e

Commits on Aug 6, 2019

• fix clang tidy errors around router/mock.h by removing empty destructors.

  Show description for 4e57308
  stevenzzzz

  committed
  4e57308

Commits on Aug 8, 2019

• move empty ctors,destructors back to cc file

  Show description for 710c7e8
  stevenzzzz

  committed
  710c7e8

• Merge branch 'master' of https://github.com/envoyproxy/envoy

  Show description for 53081b2
  stevenzzzz

  committed
  53081b2

• merge with upstream master

  Show description for 2593bfa
  stevenzzzz

  committed
  2593bfa

Commits on Aug 12, 2019

• fix a race condition, in SRDS onConfigUpdate, when calling applyConfigUpdate, the complete_cb which holds a RouteConfigInfo shared_ptr may get destructed at last, after the complete_cb is posted ba…

  Show description for 2dd6714
  stevenzzzz

  committed
  2dd6714

• add more review fixes

  Show description for cef747d
  stevenzzzz

  committed
  cef747d

Commits on Aug 13, 2019

• disable cleanup timer on SRDS subscription destruction

  Show description for bb0cdb8
  stevenzzzz

  committed
  bb0cdb8

• update comment on initManager overriding

  Show description for fa6ecb1
  stevenzzzz

  committed
  fa6ecb1

Commits on Aug 20, 2019

• A bunch of update after several issues found:

  Show description for efaa891
  stevenzzzz

  committed
  efaa891

• fix-format, and fix update for htuch's comments around ScopeKey hash and overriding_init_manager.

  Show description for bf4dc23
  stevenzzzz

  committed
  bf4dc23

• Merge branch 'master' of https://github.com/envoyproxy/envoy into scoped-config-impl-refactor

  Show description for e329f49
  stevenzzzz

  committed
  e329f49

Commits on Aug 21, 2019

• split SRDS onConfigUpdate into smaller functions and some minor comment udpates

  Show description for c4719d8
  stevenzzzz

  committed
  c4719d8

• cleanup comment and remove unused header.

  Show description for 56e2876
  stevenzzzz

  committed
  56e2876

• fix a bug introduced in the most recent function splitting, adjust the comment around overriding init-manager

  Show description for d26d9b7
  stevenzzzz

  committed
  d26d9b7

Commits on Aug 22, 2019

• fixes feedbacks from Andres

  Show description for 4ab7005
  stevenzzzz

  committed
  4ab7005

• fix typo

  Show description for bf703fc
  stevenzzzz

  committed
  bf703fc

• fix nits from htuch feedbacks

  Show description for 2b375d4
  stevenzzzz

  committed
  2b375d4

• change back scope_name assignment to value, as protobuf returns a refernce instead of a string value alreay

  Show description for c7a241c
  stevenzzzz

  committed
  c7a241c

• fix nits

  Show description for c2ff015
  stevenzzzz

  committed
  c2ff015

• merge w/ upstream master

  Show description for eb5af9c
  stevenzzzz

  committed
  eb5af9c