Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TESTING DO NOT MERGE #7627

Closed
wants to merge 10 commits into from
Closed

TESTING DO NOT MERGE #7627

wants to merge 10 commits into from

Conversation

itayd
Copy link
Contributor

@itayd itayd commented Jul 18, 2019

TESTING DO NOT MERGE

@itayd
Copy link
Contributor Author

itayd commented Jul 18, 2019

/rk-bless

@repokitteh-read-only
Copy link

This PR has been blessed, meaning its repokitteh changes are in effect in this PR.

😽

Caused by: #7627 was labeled by repokitteh[bot].

see: more, trace.

@repokitteh-read-only
Copy link

CC @htuch!: Your approval is needed for changes made to api/.
CC @itayd: FYI only for changes made to api/.

😽

Caused by: #7627 was synchronize by itayd.

see: more, trace.

@itayd itayd mentioned this pull request Jul 18, 2019
Closed
@itayd
Copy link
Contributor Author

itayd commented Jul 18, 2019

/checkowners

(i'm doing this to check this command works as well)

@itayd
Copy link
Contributor Author

itayd commented Jul 18, 2019

/checkowners

@itayd
Copy link
Contributor Author

itayd commented Jul 18, 2019

oh it did work, updated only status.

this should also comment:

/checkowners!

@repokitteh-read-only
Copy link

CC @htuch: Your approval is needed for changes made to api/.
CC @itayd: FYI only for changes made to api/.

😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@repokitteh-read-only
Copy link

CC @htuch: Your approval is needed for changes made to api/.
CC @envoy/testers: FYI only for changes made to api/.

😽

Caused by: #7627 was synchronize by itayd.

see: more, trace.

@repokitteh-read-only
Copy link

CC @htuch: Your approval is needed for changes made to api/.
CC @envoyproxy/testers: FYI only for changes made to api/.

😽

Caused by: #7627 was synchronize by itayd.

see: more, trace.

rktest2
rktest2 previously approved these changes Jul 20, 2019
View reviewed changes
@rktest2
Copy link

rktest2 commented Jul 20, 2019

/checkowners
/rk-ping

@repokitteh-read-only
Copy link

pong

😽

Caused by: a #7627 (comment) was created by @rktest2.

see: more, trace.

@repokitteh-read-only
Copy link

CC @htuch: FYI only for changes made to api/.
CC @envoyproxy/testers: Your approval is needed for changes made to api/.

😽

Caused by: #7627 was synchronize by itayd.

see: more, trace.

@repokitteh-read-only
Copy link

CC @htuch: FYI only for changes made to api/.
CC @envoyproxy/testers: Your approval is needed for changes made to api/.
CC @rktest2: FYI only for changes made to api/.

😽

Caused by: #7627 was synchronize by itayd.

see: more, trace.

@repokitteh-read-only
Copy link

CC @htuch: FYI only for changes made to api/.
CC @envoyproxy/testers: Your approval is needed for changes made to api/.
CC @rktest2: Your approval is needed for changes made to api/.

😽

Caused by: #7627 was synchronize by itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners
/rk-ping

@repokitteh-read-only
Copy link

🙀 Error while processing event:

evaluation error
error: too many arguments for format string
😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners
/rk-ping

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners
/rk-ping

@repokitteh-read-only
Copy link

🙀 Error while processing event:

evaluation error
error: github.com/repokitteh/modules/ownerscheck.star#o2:39:17: got for, want ','
😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners
/rk-ping

@repokitteh-read-only
Copy link

🙀 Error while processing event:

evaluation error
error: github.com/repokitteh/modules/ownerscheck.star#o2:38:29: undefined: a
😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners
/rk-ping

@repokitteh-read-only
Copy link

🙀 Error while processing event:

evaluation error
error: github.com/repokitteh/modules/ownerscheck.star#o2:38:29: undefined: a
😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners
/rk-ping

@repokitteh-read-only
Copy link

🙀 Error while processing event:

evaluation error
error: not enough arguments for format string
😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners
/rk-ping

@repokitteh-read-only
Copy link

pong

😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

rktest2
rktest2 previously approved these changes Jul 20, 2019
View reviewed changes
@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners
/rk-ping

@itayd itayd closed this Jul 20, 2019
@itayd itayd reopened this Jul 20, 2019
@repokitteh-read-only
Copy link

pong

😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners
/rk-ping

@repokitteh-read-only
Copy link

pong

😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners!
/rk-ping

@repokitteh-read-only
Copy link

😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@repokitteh-read-only
Copy link

pong

😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners!
/rk-ping

@repokitteh-read-only
Copy link

pong

😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

/checkowners!
/rk-ping

@repokitteh-read-only
Copy link

pong

😽

Caused by: a #7627 (comment) was created by @itayd.

see: more, trace.

@repokitteh-read-only
Copy link

CC @envoyproxy/testers: Your approval is needed for changes made to api/.
CC @rktest2: Your approval is needed for changes made to api/.

😽

Caused by: #7627 was synchronize by itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Jul 20, 2019

CC @envoyproxy/testers: Your approval is needed for changes made to api/.

@itayd itayd closed this Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rktest2 rktest2 rktest2 approved these changes

Assignees
No one assigned
Labels
rk:blessed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itayd @rktest2