clang-tidy: enable checks that don't have existing errors for performance-* #7662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Argueta <dereka@pinterest.com>
derekargueta
force-pushed
the
dereka/clang-tidy-errors
branch
from
65447b0 to
5c825dc
Compare
Signed-off-by: Derek Argueta <dereka@pinterest.com>
derekargueta
changed the title
|
Changed this to just |
Signed-off-by: Derek Argueta <dereka@pinterest.com>
lizan
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The checks enabled as errors in this diff do not have existing violations in the codebase. Enabling them as errors prevents regressions on these checks.
Risk Level: Low
Testing: Re-run clang-tidy and verified it passes.
Docs Changes: N/A
Release Notes: N/A