clang-tidy: clang-analyzer-core.DivideZero #7765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Argueta <dereka@pinterest.com>
derekargueta
commented
Jul 30, 2019
| } // namespace Envoy |
There was a problem hiding this comment.
an incidental change picked up by my vim settings, but leaving it in since we probably want all files to end with newline.
There was a problem hiding this comment.
It would be nice to make the formatter deal with this...
mattklein123
approved these changes
Jul 30, 2019
| } // namespace Envoy |
There was a problem hiding this comment.
It would be nice to make the formatter deal with this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
clang-analyzer-core.DivideZerochecks all possible codepaths for division by zero, for which we had one case. Fixed the existing case and enabled as an error to prevent regressions.Risk Level: low
Testing: existing
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Derek Argueta dereka@pinterest.com