clang-tidy: modernize-loop-convert #7790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
|
/retest |
|
🔨 rebuilding |
mattklein123
requested changes
Aug 2, 2019
| @@ -23,11 +23,11 @@ bool RoleBasedAccessControlEngineImpl::allowed(const Network::Connection& connec | |||
| std::string* effective_policy_id) const { | |||
| bool matched = false; | |||
|
|
|||
| for (auto it = policies_.begin(); it != policies_.end(); it++) { | |||
| if (it->second.matches(connection, headers, metadata)) { | |||
| for (const auto& policie : policies_) { | |||
There was a problem hiding this comment.
Hmm, wonder why spelling CI didn't catch this when it caught another one that was very similar: 5203b0e
Signed-off-by: Derek Argueta <dereka@pinterest.com>
lizan
approved these changes
Aug 3, 2019
mattklein123
approved these changes
Aug 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Enable and fix existing cases of
modernize-loop-convert. This clang-tidy check looks for raw for-loops that can be replaced with range-based loops.https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html
There are a few configuration options for this check (see above link for more details) but I think the defaults are perfectly suitable.
Risk Level: Low
Testing: Existing
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue]
[Optional Deprecated:]
Signed-off-by: Derek Argueta dereka@pinterest.com