Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: More StatName conversions #7810

Merged
merged 13 commits into from
Aug 8, 2019

Conversation

jmarantz
Copy link
Contributor

@jmarantz jmarantz commented Aug 2, 2019

Description: Avoid using scope.counter(string) in Zookeeper and ExtAuthz, factoring out some infrastructure for looking up dynamically constructed stat-names for shared use. 6 more files to go and then #4980 can hopefuly be merged, addressing #4196.
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz jmarantz requested a review from snowp as a code owner August 2, 2019 13:16
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Contributor Author

jmarantz commented Aug 2, 2019

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: compile_time_options (failed build)

🐱

Caused by: a #7810 (comment) was created by @jmarantz.

see: more, trace.

@jmarantz
Copy link
Contributor Author

jmarantz commented Aug 4, 2019

@lizan I had previously thought this PR was all green; but now it's in this "waiting for status..." state. How do I trigger a re-test for this flavor of CI?

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, just some style comments

source/extensions/filters/http/dynamo/dynamo_stats.cc Outdated Show resolved Hide resolved
source/common/stats/symbol_table_impl.h Show resolved Hide resolved
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a high level this LGTM, will defer to @snowp for review.

@mattklein123 mattklein123 removed their assignment Aug 6, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Contributor Author

jmarantz commented Aug 8, 2019

Any other comments? This is blocking the reviewability of #7842 which I think is the last thing we need prior to reviewing #4980 and thus resolving #4196 .

Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmarantz
Copy link
Contributor Author

jmarantz commented Aug 8, 2019

Thanks @snowp -- @envoyproxy/senior-maintainers can I get another round of approval?

@jmarantz jmarantz merged commit 3fdd00d into envoyproxy:master Aug 8, 2019
@jmarantz jmarantz deleted the more-statname-conversions branch August 8, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants