bazel: branch cc_configure from bazel repo to support libstdc++/libgc… #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If possible can you split this into two PRs:
It will be easier to review, and easier to rebase if we have to merge upstream later. |
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 18, 2017
… at d6fec93. This is a clean import to support making clear what is going on in envoyproxy#782.
…c static linking. We import cc_configure.bzl from https://github.com/bazelbuild/bazel at d6fec93 in this patch. This allows us to workaround bazelbuild/bazel#2840 (see the header comment for further details).
|
Now rebased on top of #787. |
| if "CC" in repository_ctx.os.environ: | ||
| cc_name = repository_ctx.os.environ["CC"].strip() | ||
| cc_name = "g++" | ||
| if "CXX" in repository_ctx.os.environ: |
There was a problem hiding this comment.
So we need to make sure we set CXX now?
|
Yeah, if compiler isn't g++ in the path.
…On Tue, Apr 18, 2017 at 6:41 PM Matt Klein ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In bazel/cc_configure.bzl
<#782 (comment)>:
> @@ -387,18 +395,18 @@ def _get_system_root(repository_ctx):
def _find_cc(repository_ctx):
"""Find the C++ compiler."""
- cc_name = "gcc"
- if "CC" in repository_ctx.os.environ:
- cc_name = repository_ctx.os.environ["CC"].strip()
+ cc_name = "g++"
+ if "CXX" in repository_ctx.os.environ:
So we need to make sure we set CXX now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#782 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKaLv8mz-xKCU2x5rI-OdnhUJedcBpmiks5rxTwugaJpZM4NAi6m>
.
|
clnperez
pushed a commit
to clnperez/envoy
that referenced
this pull request
Mar 28, 2018
… at d6fec93. (envoyproxy#787) This is a clean import to support making clear what is going on in envoyproxy#782.
clnperez
pushed a commit
to clnperez/envoy
that referenced
this pull request
Apr 3, 2018
… at d6fec93. (envoyproxy#787) This is a clean import to support making clear what is going on in envoyproxy#782.
clnperez
pushed a commit
to clnperez/envoy
that referenced
this pull request
Apr 3, 2018
… at d6fec93. (envoyproxy#787) This is a clean import to support making clear what is going on in envoyproxy#782.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c static linking.
We import cc_configure.bzl from https://github.com/bazelbuild/bazel at d6fec93 in this patch.
This allows us to workaround bazelbuild/bazel#2840 (see the header comment for further details).