Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft v3alpha API boost #9481

Closed
wants to merge 3 commits into from
Closed

Conversation

htuch
Copy link
Member

@htuch htuch commented Dec 26, 2019

This is a staging PR to demonstrate what the final v3alpha API boost will look like, and what remains to be upstreamed before the automated upgrade.

This PR will be force squashed as changes occur, and will have the structure of 3 patches:

  1. WiP API booster (this is being upstreamed) [also includes shadow generation]
  2. API booster application. This is fully automated and is the bulk of the PR
  3. Post API booster manual fixups. Various PRs will be proposed to minimize this.

This branch should have all tests passing and demonstrates what the final tree will look post-boosting.

Fixes #8082

Everything in here will be upstreamed via in-flight PRs.

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Working to move as much of this as possible into upstream.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Member Author

htuch commented Dec 26, 2019

@mattklein123 @lizan it would be helpful if you folks can look at this from the perspective of what the end state of the tree is proposed to look like. This is the main thing we need to land shortly to prepare for v3 in 1.13.0.

@htuch htuch added the api/v3 Major version release @ end of Q3 2019 label Dec 26, 2019
htuch added a commit to htuch/envoy that referenced this pull request Dec 27, 2019
This provides the support needed to perform the full v2 --> v3 alpha
upgrade (as demoed in envoyproxy#9481).

Specifically:

* Support added for deprecations via hidden_envoy_deprecated shadow aliases.

* Constant and enum renaming, inside and outside of macros.

* Some simplifications as we no longer need to deal with mangled enum
  constants (see envoyproxy#9450).

* Fixed support for validation header inference (there was bit rot as
  tests were missing, added tests).

Risk level: Low
Testing: Additional golden tests added for api_boost.py, ran upgrade on
  entire Envoy source tree.

Signed-off-by: Harvey Tuch <htuch@google.com>
@stale
Copy link

stale bot commented Jan 2, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 2, 2020
htuch added a commit that referenced this pull request Jan 2, 2020
This provides the support needed to perform the full v2 --> v3 alpha
upgrade (as demoed in #9481).

Specifically:

* Support added for deprecations via hidden_envoy_deprecated shadow aliases.

* Constant and enum renaming, inside and outside of macros.

* Some simplifications as we no longer need to deal with mangled enum
  constants (see #9450).

* Fixed support for validation header inference (there was bit rot as
  tests were missing, added tests).

Risk level: Low
Testing: Additional golden tests added for api_boost.py, ran upgrade on
  entire Envoy source tree.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch closed this Jan 3, 2020
prakhag1 pushed a commit to prakhag1/envoy that referenced this pull request Jan 3, 2020
This provides the support needed to perform the full v2 --> v3 alpha
upgrade (as demoed in envoyproxy#9481).

Specifically:

* Support added for deprecations via hidden_envoy_deprecated shadow aliases.

* Constant and enum renaming, inside and outside of macros.

* Some simplifications as we no longer need to deal with mangled enum
  constants (see envoyproxy#9450).

* Fixed support for validation header inference (there was bit rot as
  tests were missing, added tests).

Risk level: Low
Testing: Additional golden tests added for api_boost.py, ran upgrade on
  entire Envoy source tree.

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Prakhar <prakhar_au@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/v3 Major version release @ end of Q3 2019 stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 -> v3 API translation
3 participants