-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align gateway class supported features with upstream changes #4059
Comments
my vote is to turn it on when the field becomes stable (else it introduces a lot of breaking changes) or when we have many users asking for this |
@arkodg I aligned how we update supported features in the gateway class status. To do so, I used the following version of gateway-api: While testing it out, I saw another breaking change (as the code could no longer compile):
Is this known and addressed in another issue? If not, I think we have two options:
I think the 2nd way is the way to go, but please let me know what you prefer. |
hey @levikobi, we discussed this in the community meeting this week and decided that we should put this on hold until the feature is stable since we feel that this feature doesnt add any extra value yet |
No problem |
Description:
kubernetes-sigs/gateway-api#3200 introduced a breaking change to SupportedFeatures experimental API. We need to align the controller with the new API structure.
[optional Relevant Links:]
The text was updated successfully, but these errors were encountered: