disable writing into GatewayClass.Status.SupportedFeatures #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
previously approved these changes
Jul 18, 2024
disable until the field moves from experiemental to stable so status writes for a GatewayClass dont fail when the datatypes differ Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
force-pushed
the
disable-supportedfeatures
branch
from
4c46c4e
to
c812037
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3888 +/- ##
==========================================
- Coverage 67.34% 67.31% -0.04%
==========================================
Files 182 182
Lines 22391 22390 -1
==========================================
- Hits 15079 15071 -8
- Misses 6224 6228 +4
- Partials 1088 1091 +3 ☔ View full report in Codecov by Sentry. |
Alice-Lilith
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable until the field moves from experiemental to stable so status writes for a GatewayClass dont fail when the datatypes differ
Relates to a breaking change soon to be introduced in kubernetes-sigs/gateway-api#3200.