GetParentReferences should use namespace from RouteContext

[zirain]

fix: #3872

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (7cbbcb5) to head (6f28b2f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3876      +/-   ##
==========================================
- Coverage   69.36%   69.30%   -0.06%     
==========================================
  Files         176      176              
  Lines       21754    21758       +4     
==========================================
- Hits        15089    15079      -10     
- Misses       5577     5588      +11     
- Partials     1088     1091       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arkodg]

is this a regression from #3532 ?

[zirain]

is this a regression from #3532 ?

looks like not

// GetParentReferences returns the ParentReference of the Route object.
func GetParentReferences(route RouteContext) []gwapiv1.ParentReference {
	rv := reflect.ValueOf(route).Elem()
	kind := rv.FieldByName("Kind").String()
	pr := rv.FieldByName("Spec").FieldByName("ParentRefs")
	if kind == KindHTTPRoute || kind == KindGRPCRoute {
		return pr.Interface().([]gwapiv1.ParentReference)
	}

	parentReferences := make([]gwapiv1.ParentReference, pr.Len())
	for i := 0; i < len(parentReferences); i++ {
		p := pr.Index(i).Interface().(gwapiv1.ParentReference)
		parentReferences[i] = UpgradeParentReference(p)
	}
	return parentReferences
}

[arkodg]

LGTM thanks !

[zirain]

hold for a while

[zirain]

@arkodg I think now we have the right fix.

[arkodg]

LGTM thanks !