-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix grammar error --> Typo in envoy-patch-policy.md "garunteed" #3892
base: main
Are you sure you want to change the base?
Conversation
FIxed the typo of "garunteed" into "guaranteed" Signed-off-by: gwarren3210 <98773623+gwarren3210@users.noreply.github.com>
hey thanks for fixing this @gwarren3210 !
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3892 +/- ##
==========================================
- Coverage 67.43% 67.37% -0.07%
==========================================
Files 183 183
Lines 22437 22437
==========================================
- Hits 15130 15116 -14
- Misses 6220 6230 +10
- Partials 1087 1091 +4 ☔ View full report in Codecov by Sentry. |
|
Yes, docs directory is auto-generated. |
not output from codespell |
@gwarren3210 Please run |
I am able to run it on my local machine without any changes happening to files but when running it in github.dev I get the following error. Also running it on my local machine did not generate any files.
|
linux: sudo apt-get install libbtrfs-dev -y |
I run into the same issue of it not changing any of the files. It passes all the tests locally, is it possible that a test is broken? |
no, it just because you lack of some lib that is needed by this project. |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
@gwarren3210 still plan to move this forward? |
FIxed the typo of "garunteed" into "guaranteed"
What type of PR is this?
docs: fix grammar error