Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix grammar error --> Typo in envoy-patch-policy.md "garunteed" #3892

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gwarren3210
Copy link

FIxed the typo of "garunteed" into "guaranteed"

What type of PR is this?
docs: fix grammar error

FIxed the typo of "garunteed" into "guaranteed"

Signed-off-by: gwarren3210 <98773623+gwarren3210@users.noreply.github.com>
@gwarren3210 gwarren3210 requested a review from a team as a code owner July 18, 2024 20:23
@arkodg
Copy link
Contributor

arkodg commented Jul 18, 2024

hey thanks for fixing this @gwarren3210 !

  1. @zirain @zhaohuabing with the new doc infra changes in place, will someone need to update 3 files having the same content ?
  2. also why did codespell not catch this

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.37%. Comparing base (92782a8) to head (64dfc84).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3892      +/-   ##
==========================================
- Coverage   67.43%   67.37%   -0.07%     
==========================================
  Files         183      183              
  Lines       22437    22437              
==========================================
- Hits        15130    15116      -14     
- Misses       6220     6230      +10     
- Partials     1087     1091       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Contributor

zirain commented Jul 19, 2024

hey thanks for fixing this @gwarren3210 !

  1. @zirain @zhaohuabing with the new doc infra changes in place, will someone need to update 3 files having the same content ?
  2. also why did codespell not catch this
  1. you should always change content under latest or v[x].[y], make gen-chek will do the copy.
  2. let me check why.

@zhaohuabing
Copy link
Member

Yes, docs directory is auto-generated.

@zirain
Copy link
Contributor

zirain commented Jul 19, 2024

codespell site/content/en/latest/tasks/extensibility/envoy-patch-policy.md

not output from codespell

@zhaohuabing
Copy link
Member

@gwarren3210 Please run make gen-check and submit the generated files to fix the gen-check.

@gwarren3210
Copy link
Author

gwarren3210 commented Jul 22, 2024

I am able to run it on my local machine without any changes happening to files but when running it in github.dev I get the following error. Also running it on my local machine did not generate any files.

go test -timeout 30s github.com/envoyproxy/gateway/internal/cmd/egctl --override-testdata=true
# github.com/containers/storage/drivers/btrfs
/go/pkg/mod/github.com/containers/storage@v1.54.0/drivers/btrfs/btrfs.go:12:10: fatal error: btrfs/ioctl.h: No such file or directory
   12 | #include <btrfs/ioctl.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
FAIL    github.com/envoyproxy/gateway/internal/cmd/egctl [build failed]
FAIL
make[1]: *** [tools/make/golang.mk:51: go.testdata.complete] Error 1
make[1]: Leaving directory '/workspaces/gateway'
make: *** [Makefile:18: _run] Error 2

@zirain
Copy link
Contributor

zirain commented Jul 22, 2024

I am able to run it on my local machine without any changes happening to files but when running it in github.dev I get the following error. Also running it on my local machine did not generate any files.

go test -timeout 30s github.com/envoyproxy/gateway/internal/cmd/egctl --override-testdata=true
# github.com/containers/storage/drivers/btrfs
/go/pkg/mod/github.com/containers/storage@v1.54.0/drivers/btrfs/btrfs.go:12:10: fatal error: btrfs/ioctl.h: No such file or directory
   12 | #include <btrfs/ioctl.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
FAIL    github.com/envoyproxy/gateway/internal/cmd/egctl [build failed]
FAIL
make[1]: *** [tools/make/golang.mk:51: go.testdata.complete] Error 1
make[1]: Leaving directory '/workspaces/gateway'
make: *** [Makefile:18: _run] Error 2

linux: sudo apt-get install libbtrfs-dev -y
macos: brew install libffi

@gwarren3210
Copy link
Author

I am able to run it on my local machine without any changes happening to files but when running it in github.dev I get the following error. Also running it on my local machine did not generate any files.

go test -timeout 30s github.com/envoyproxy/gateway/internal/cmd/egctl --override-testdata=true
# github.com/containers/storage/drivers/btrfs
/go/pkg/mod/github.com/containers/storage@v1.54.0/drivers/btrfs/btrfs.go:12:10: fatal error: btrfs/ioctl.h: No such file or directory
   12 | #include <btrfs/ioctl.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
FAIL    github.com/envoyproxy/gateway/internal/cmd/egctl [build failed]
FAIL
make[1]: *** [tools/make/golang.mk:51: go.testdata.complete] Error 1
make[1]: Leaving directory '/workspaces/gateway'
make: *** [Makefile:18: _run] Error 2

linux: sudo apt-get install libbtrfs-dev -y macos: brew install libffi

I run into the same issue of it not changing any of the files. It passes all the tests locally, is it possible that a test is broken?

@zirain
Copy link
Contributor

zirain commented Jul 25, 2024

I am able to run it on my local machine without any changes happening to files but when running it in github.dev I get the following error. Also running it on my local machine did not generate any files.

go test -timeout 30s github.com/envoyproxy/gateway/internal/cmd/egctl --override-testdata=true
# github.com/containers/storage/drivers/btrfs
/go/pkg/mod/github.com/containers/storage@v1.54.0/drivers/btrfs/btrfs.go:12:10: fatal error: btrfs/ioctl.h: No such file or directory
   12 | #include <btrfs/ioctl.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
FAIL    github.com/envoyproxy/gateway/internal/cmd/egctl [build failed]
FAIL
make[1]: *** [tools/make/golang.mk:51: go.testdata.complete] Error 1
make[1]: Leaving directory '/workspaces/gateway'
make: *** [Makefile:18: _run] Error 2

linux: sudo apt-get install libbtrfs-dev -y macos: brew install libffi

I run into the same issue of it not changing any of the files. It passes all the tests locally, is it possible that a test is broken?

no, it just because you lack of some lib that is needed by this project.

Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 24, 2024
@zirain
Copy link
Contributor

zirain commented Oct 23, 2024

@gwarren3210 still plan to move this forward?

@github-actions github-actions bot removed the stale label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants