-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use tabs to show different installation types #3916
Conversation
Signed-off-by: Manoramsharma <img_2020037@iiitm.ac.in>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3916 +/- ##
==========================================
- Coverage 67.43% 67.38% -0.06%
==========================================
Files 183 183
Lines 22435 22435
==========================================
- Hits 15130 15117 -13
- Misses 6218 6228 +10
- Partials 1087 1090 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manoramsharma <img_2020037@iiitm.ac.in>
as the [Helm install method](./install-helm), so if you need more control over your Envoy Gateway | ||
installation, it is recommended that you use helm. | ||
|
||
## Before you begin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can move this paragraph out of tabpane
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zirain I tried to move this out of tabpane but it became static and was not able to switch with the switching tabs. Should I attach a preview of it after making it out of tabpane?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version Compatibility Matrix
part should be moved out of tabpane.
I'm sorry, but you should not direct edit content |
What type of PR is this?
Docs feature enhancement
What this PR does / why we need it:
This PR is made to enhance the docs, making it more presentable using tabpane installation.
Which issue(s) this PR fixes:
Fixes #3133
Before
After