Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use tabs to show different installation types #3916

Closed
wants to merge 3 commits into from

Conversation

Manoramsharma
Copy link
Contributor

What type of PR is this?
Docs feature enhancement

What this PR does / why we need it:

This PR is made to enhance the docs, making it more presentable using tabpane installation.

Which issue(s) this PR fixes:

Fixes #3133

Before
Screenshot 2024-07-21 at 11 29 00 PM

After
Screenshot 2024-07-21 at 11 29 45 PM
Screenshot 2024-07-21 at 11 30 04 PM

Signed-off-by: Manoramsharma <img_2020037@iiitm.ac.in>
@Manoramsharma Manoramsharma requested a review from a team as a code owner July 21, 2024 18:00
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.38%. Comparing base (fda9376) to head (4a627b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3916      +/-   ##
==========================================
- Coverage   67.43%   67.38%   -0.06%     
==========================================
  Files         183      183              
  Lines       22435    22435              
==========================================
- Hits        15130    15117      -13     
- Misses       6218     6228      +10     
- Partials     1087     1090       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Contributor

zirain commented Jul 22, 2024

image this looks not right

Signed-off-by: Manoramsharma <img_2020037@iiitm.ac.in>
@Manoramsharma
Copy link
Contributor Author

image this looks not right

Yes, this was because of the alert feature used under the the tabpane

image this looks not right

Resolved it 👍

as the [Helm install method](./install-helm), so if you need more control over your Envoy Gateway
installation, it is recommended that you use helm.

## Before you begin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move this paragraph out of tabpane

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zirain I tried to move this out of tabpane but it became static and was not able to switch with the switching tabs. Should I attach a preview of it after making it out of tabpane?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version Compatibility Matrix part should be moved out of tabpane.

@Manoramsharma
Copy link
Contributor Author

Screenshot 2024-07-22 at 3 06 21 PM

See Now this is not changing with the changing tabs?

@zirain
Copy link
Contributor

zirain commented Jul 22, 2024

I'm sorry, but you should not direct edit content /docs, it alias to current version, that's why you see ci gen-check fails.
More info can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: use tabs to show different installation types
2 participants