add benchmark memory profiles into report #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3951 +/- ##
==========================================
+ Coverage 67.39% 67.61% +0.22%
==========================================
Files 183 183
Lines 22443 22406 -37
==========================================
+ Hits 15125 15150 +25
+ Misses 6228 6179 -49
+ Partials 1090 1077 -13 ☔ View full report in Codecov by Sentry. |
|
@shawnh2 plz fix the lint errors |
shawnh2
force-pushed
the
benchmark-mem-profile
branch
from
8bb1840
to
a308f74
Compare
shawnh2
force-pushed
the
benchmark-mem-profile
branch
from
a308f74
to
f0ed640
Compare
arkodg
reviewed
Jul 29, 2024
|
Hold for now, need to investigate why the benchmark test in CI is failing. |
|
/retest |
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
cnvergence
approved these changes
Jul 30, 2024
arkodg
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
giving a detailed report of memory usage, preview:
Which issue(s) this PR fixes:
xref: #3698